From: Jesse T <mr.bossman075@gmail.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org,
Arnd Bergmann <arnd@arndb.de>,
"Jason A . Donenfeld" <Jason@zx2c4.com>,
wireguard@lists.zx2c4.com, linux-arch@vger.kernel.org,
linux-snps-arc@lists.infradead.org,
Vineet Gupta <vgupta@kernel.org>, Brian Cain <bcain@quicinc.com>,
linux-hexagon@vger.kernel.org,
Greg Ungerer <gerg@linux-m68k.org>,
linux-m68k@lists.linux-m68k.org, Michal Simek <monstr@monstr.eu>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Dinh Nguyen <dinguyen@kernel.org>,
Jonas Bonn <jonas@southpole.se>,
Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
Stafford Horne <shorne@gmail.com>,
linux-openrisc@vger.kernel.org, linux-mips@vger.kernel.org,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
linux-sh@vger.kernel.org, Max Filippov <jcmvbkbc@gmail.com>,
Josh Triplett <josh@joshtriplett.org>,
Masahiro Yamada <masahiroy@kernel.org>,
linux-kbuild@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] treewide: drop CONFIG_EMBEDDED
Date: Fri, 18 Aug 2023 23:33:49 -0400 [thread overview]
Message-ID: <CAJFTR8T-Fdu_aKapP+Lb6pLYo_ykXwXw6rFZNGR5=WKU1QwUPQ@mail.gmail.com> (raw)
In-Reply-To: <78a802c5-3f0d-e199-d974-e586c00180eb@infradead.org>
On Fri, Aug 18, 2023 at 7:44 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> Hi Jesse,
>
> I replied to your comment a few days ago, but for some reason
> your email to me contains:
> Reply-To: 20230816055010.31534-1-rdunlap@infradead.org
> so it wasn't sent directly to you.
Sorry about that I messed up the email headers...
>
> My former reply is below.
>
> On 8/16/23 20:15, Randy Dunlap wrote:
> > Hi Jesse,
> >
> > On 8/16/23 15:45, Jesse Taube wrote:
> >> Hi, Randy
> >>
> >>> diff -- a/init/Kconfig b/init/Kconfig
> >>> --- a/init/Kconfig
> >>> +++ b/init/Kconfig
> >>> @@ -1790,14 +1790,6 @@ config DEBUG_RSEQ
> >>>
> >>> If unsure, say N.
> >>>
> >>> -config EMBEDDED
> >>> - bool "Embedded system"
> >>> - select EXPERT
> >>> - help
> >>> - This option should be enabled if compiling the kernel for
> >>> - an embedded system so certain expert options are available
> >>> - for configuration.
> >>
> >> Wouldn't removing this break many out of tree configs?
> >
> > I'm not familiar with out-of-tree configs.
> > Do you have some examples of some that use CONFIG_EMBEDDED?
> > (not distros)
Buildroot has a few.
It won't immediately break Buildroot and Yocto as they have a set version,
but it could be confusing for anyone updating the kernel.
> >
> >> Should there be a warning here to update change it instead of removal?
> >
> > kconfig doesn't have a warning mechanism AFAIK.
> > Do you have an idea of how this would work?
No, unfortunately. As you said without a warning it would be overlooked so
a change would not be necessary.
A possible solution is to check in a header file with:
#ifdef CONFIG_EMBEDDED
#warning "CONFIG_EMBEDDED has changed to CONFIG_EXPERT"
#endif
Does anyone else have an opinion on this?
Since kconfig doesn't have a warning mechanism the patch seems fine as is.
Thanks,
Jesse Taube
> >
> > We could make a smaller change to init/Kconfig, like so:
> >
> > config EMBEDDED
> > - bool "Embedded system"
> > + bool "Embedded system (DEPRECATED)"
> > select EXPERT
> > help
> > - This option should be enabled if compiling the kernel for
> > - an embedded system so certain expert options are available
> > - for configuration.
> > + This option is being removed after Linux 6.6.
> > + Use EXPERT instead of EMBEDDED.
> >
> > but there is no way to produce a warning message. I.e., even with this
> > change, the message will probably be overlooked.
> >
> > ---
> > ~Randy
>
> --
> ~Randy
next prev parent reply other threads:[~2023-08-19 20:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 22:45 Jesse Taube
2023-08-17 3:15 ` Randy Dunlap
2023-08-18 23:44 ` Randy Dunlap
2023-08-19 3:33 ` Jesse T [this message]
2023-08-19 8:53 ` Christophe Leroy
-- strict thread matches above, loose matches on Subject: below --
2023-08-16 5:50 Randy Dunlap
2023-08-16 7:41 ` Geert Uytterhoeven
2023-08-16 13:11 ` Arnd Bergmann
2023-08-16 14:32 ` Palmer Dabbelt
2023-08-16 22:11 ` Greg Ungerer
2023-08-16 22:58 ` Jason A. Donenfeld
2023-08-17 4:38 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFTR8T-Fdu_aKapP+Lb6pLYo_ykXwXw6rFZNGR5=WKU1QwUPQ@mail.gmail.com' \
--to=mr.bossman075@gmail.com \
--cc=Jason@zx2c4.com \
--cc=akpm@linux-foundation.org \
--cc=aou@eecs.berkeley.edu \
--cc=arnd@arndb.de \
--cc=bcain@quicinc.com \
--cc=christophe.leroy@csgroup.eu \
--cc=dalias@libc.org \
--cc=dinguyen@kernel.org \
--cc=gerg@linux-m68k.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=jcmvbkbc@gmail.com \
--cc=jonas@southpole.se \
--cc=josh@joshtriplett.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-openrisc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=masahiroy@kernel.org \
--cc=monstr@monstr.eu \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=rdunlap@infradead.org \
--cc=shorne@gmail.com \
--cc=stefan.kristiansson@saunalahti.fi \
--cc=tsbogend@alpha.franken.de \
--cc=vgupta@kernel.org \
--cc=wireguard@lists.zx2c4.com \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).