From: "Aurélien Chabot" <aurelien@chabot.fr>
To: Mathias Hall-Andersen <mathias@hall-andersen.dk>
Cc: wireguard@lists.zx2c4.com
Subject: Re: WireGuard root-less support for android
Date: Tue, 23 Jan 2018 01:52:30 +0000 [thread overview]
Message-ID: <CAJup9cgEfM4WVH=7Zv7=tr9kF2fN6u2_eiwPF4QfT+KmWSPgPA@mail.gmail.com> (raw)
In-Reply-To: <CAJup9ciQfnxJ8joN3bHT2Aqw3shV_=P-tQ6v-gw3RSM1R1VdPg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1438 bytes --]
Hi Mathias,
Did you had thought about the support of wireguard-go for android?
I'll be happy to rebase the work I did before on wireguard-go to get that a
new go.
Aurélien
On Thu, Nov 9, 2017 at 8:50 AM Aurélien Chabot <aurelien@chabot.fr> wrote:
> The GetUDPConn is used to forward the socket id to the Java layer. The
> android API allow to protect the socket from being route to the VPN, making
> the job of using the VPN as default route easy.
>
> About the close, good to know I am not missing something. I might spit the
> patch then, so the bug fix doesn't get stuck with the rest.
>
> Aurélien
>
> On Thu, Nov 9, 2017, 04:48 Mathias Hall-Andersen <mathias@hall-andersen.dk>
> wrote:
>
>> Hi Aurélien
>>
>> Thanks for contributing to the wireguard-go project.
>>
>> I never anticipated for the implementation to be used as a library.
>> This means that I either have to:
>>
>> 1. Settle for an API and reconsider what is exported and not.
>> 2. Give no guarantees about API stability
>>
>> Providing the functionality as a library might be the cleanest solution
>> in this case.
>> One option is to have an internal package and a small exported API.
>>
>> Is the GetUDPConn only used to wait for the device to bind?
>>
>> The missing device.tun.device.Close() is indeed a bug.
>>
>> I will look more at your patches during the weekend,
>> Thanks once again.
>>
>> Mathias
>>
>
[-- Attachment #2: Type: text/html, Size: 2065 bytes --]
prev parent reply other threads:[~2018-01-23 1:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-07 4:38 Aurélien Chabot
2017-11-07 4:38 ` [PATCH 1/4] Add wireguard-go as submodule Aurélien Chabot
2017-11-07 9:34 ` Greg KH
2017-11-07 9:53 ` Jason A. Donenfeld
2017-11-07 4:38 ` [PATCH 2/4] Add support for android in wireguard-go Aurélien Chabot
2017-11-07 4:38 ` [PATCH 3/4] Add support of wireguard-go as an Android Vpn Service Aurélien Chabot
2017-11-07 4:38 ` [PATCH 4/4] Add build instruction Aurélien Chabot
2017-11-07 4:38 ` [PATCH 1/2] Put the code in a 'wireguard' go package Aurélien Chabot
2017-11-07 4:38 ` [PATCH 2/2] Add android support Aurélien Chabot
2017-11-07 9:57 ` WireGuard root-less support for android Jason A. Donenfeld
2017-11-08 5:15 ` Samuel Holland
2017-11-08 17:44 ` Mathias Hall-Andersen
2017-11-08 21:50 ` Aurélien Chabot
2018-01-23 1:52 ` Aurélien Chabot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJup9cgEfM4WVH=7Zv7=tr9kF2fN6u2_eiwPF4QfT+KmWSPgPA@mail.gmail.com' \
--to=aurelien@chabot.fr \
--cc=mathias@hall-andersen.dk \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).