From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: jason.dusek@gmail.com Received: from krantz.zx2c4.com (localhost [127.0.0.1]) by krantz.zx2c4.com (ZX2C4 Mail Server) with ESMTP id 4aa67db9 for ; Fri, 17 Feb 2017 18:38:58 +0000 (UTC) Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by krantz.zx2c4.com (ZX2C4 Mail Server) with ESMTP id e4121119 for ; Fri, 17 Feb 2017 18:38:58 +0000 (UTC) Received: by mail-wm0-f43.google.com with SMTP id v77so16403147wmv.0 for ; Fri, 17 Feb 2017 10:39:19 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Jason Dusek Date: Fri, 17 Feb 2017 18:39:06 +0000 Message-ID: Subject: Re: [PATCH] Handle (a) changes in Screech and (b) borrow issue To: "Jason A. Donenfeld" Content-Type: multipart/alternative; boundary=001a11452e4c3a20d80548be3ba8 Cc: WireGuard mailing list List-Id: Development discussion of WireGuard List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , --001a11452e4c3a20d80548be3ba8 Content-Type: text/plain; charset=UTF-8 Hi Jason, It was necessary to "vendor" Screech. A separate Git repo makes for a cleaner patch than downloading and including all of Screech. The patch makes some stuff public again that was once public and then went private: https://github.com/solidsnack/screech/commit/6d91d075ad2f98f03c807a471953495c720a5696 I assume Trevor made them private for a reason; but also that the original developer of the client used them for a reason. I would like to better understand the application before making a suggestion as regards the Screech API; but I would also really like the Rust client to build (as I think we all would). Kind Regards, Jason Jason A. Donenfeld schrieb am Fr. 17. Feb. 2017 um 05:50: > Hey, > > Thanks for the patch. This changes the screech repository to your own. > Has Trevor agreed for you to officially take over that project? If so, > please link me to the moderncrypto mailing list post about this. If > not, why should things switch to yours rather than moving your patches > upstream to Trevor? > > Regards, > Jason > --001a11452e4c3a20d80548be3ba8 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Jason,

It was necessary to "vendor" Screech. A separate= Git repo makes for a cleaner patch than downloading and including all of S= creech. The patch makes some stuff public again that was once public and th= en went private:

https://github.com/solidsnac= k/screech/commit/6d91d075ad2f98f03c807a471953495c720a5696

I assu= me Trevor made them private for a reason; but also that the original develo= per of the client used them for a reason. I would like to better understand= the application before making a suggestion as regards the Screech API; but= I would also really like the Rust client to build (as I think we all would= ).

Kind Regards,
Jason

Jason A. Donenfeld <Jason@= zx2c4.com> schrieb am Fr. 17. Feb. 2017 um 05:50:
Hey,

Thanks for the patch. This changes the screech repository to your own.
Has Trevor agreed for you to officially take over that project? If so,
please link me to the moderncrypto mailing list post about this. If
not, why should things switch to yours rather than moving your patches
upstream to Trevor?

Regards,
Jason
--001a11452e4c3a20d80548be3ba8--