Development discussion of WireGuard
 help / color / mirror / Atom feed
From: Andrey Petrov <apetrov@vmware.com>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: "wireguard@lists.zx2c4.com" <wireguard@lists.zx2c4.com>
Subject: Re: CentOS kernel module build failure
Date: Thu, 5 Oct 2017 08:12:18 +0000	[thread overview]
Message-ID: <CY1PR0501MB15797EB039F2510EA00B0303C4700@CY1PR0501MB1579.namprd05.prod.outlook.com> (raw)
In-Reply-To: <CAHmME9qQTch=-yCfHr0xTBLk+bHBWw675WEiY8+BM58_2vq+Ug@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 3545 bytes --]

Hi Jason,


After applying the patch with 'git apply' I got:

DKMS make.log for wireguard-0.0.20171001 for kernel 3.10.0-693.2.2.el7.x86_64 (x86_64)
Thu Oct  5 08:10:00 UTC 2017
make: Entering directory `/usr/src/kernels/3.10.0-693.2.2.el7.x86_64'
  LD      /var/lib/dkms/wireguard/0.0.20171001/build/built-in.o
  CC [M]  /var/lib/dkms/wireguard/0.0.20171001/build/main.o
  CC [M]  /var/lib/dkms/wireguard/0.0.20171001/build/noise.o
  CC [M]  /var/lib/dkms/wireguard/0.0.20171001/build/device.o
  CC [M]  /var/lib/dkms/wireguard/0.0.20171001/build/peer.o
  CC [M]  /var/lib/dkms/wireguard/0.0.20171001/build/timers.o
  CC [M]  /var/lib/dkms/wireguard/0.0.20171001/build/queueing.o
  CC [M]  /var/lib/dkms/wireguard/0.0.20171001/build/send.o
  CC [M]  /var/lib/dkms/wireguard/0.0.20171001/build/receive.o
  CC [M]  /var/lib/dkms/wireguard/0.0.20171001/build/socket.o
  CC [M]  /var/lib/dkms/wireguard/0.0.20171001/build/hashtables.o
  CC [M]  /var/lib/dkms/wireguard/0.0.20171001/build/routingtable.o
  CC [M]  /var/lib/dkms/wireguard/0.0.20171001/build/ratelimiter.o
  CC [M]  /var/lib/dkms/wireguard/0.0.20171001/build/cookie.o
  CC [M]  /var/lib/dkms/wireguard/0.0.20171001/build/netlink.o
/var/lib/dkms/wireguard/0.0.20171001/build/netlink.c: In function ‘netlink_init’:
/var/lib/dkms/wireguard/0.0.20171001/build/netlink.c:488:42: error: macro "genl_register_family_with_ops" passed 3 arguments, but takes just 2
  return genl_register_family(&genl_family);
                                          ^
In file included from <command-line>:0:0:
/var/lib/dkms/wireguard/0.0.20171001/build/compat/compat.h:437:33: error: ‘genl_register_family_with_ops’ undeclared (first use in this function)
 #define genl_register_family(a) genl_register_family_with_ops(a, (struct genl_ops *)genl_ops, ARRAY_SIZE(genl_ops))
                                 ^
/var/lib/dkms/wireguard/0.0.20171001/build/netlink.c:488:9: note: in expansion of macro ‘genl_register_family’
  return genl_register_family(&genl_family);
         ^
/var/lib/dkms/wireguard/0.0.20171001/build/compat/compat.h:437:33: note: each undeclared identifier is reported only once for each function it appears in
 #define genl_register_family(a) genl_register_family_with_ops(a, (struct genl_ops *)genl_ops, ARRAY_SIZE(genl_ops))
                                 ^
/var/lib/dkms/wireguard/0.0.20171001/build/netlink.c:488:9: note: in expansion of macro ‘genl_register_family’
  return genl_register_family(&genl_family);
         ^
/var/lib/dkms/wireguard/0.0.20171001/build/netlink.c:489:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^
make[1]: *** [/var/lib/dkms/wireguard/0.0.20171001/build/netlink.o] Error 1
make: *** [_module_/var/lib/dkms/wireguard/0.0.20171001/build] Error 2
make: Leaving directory `/usr/src/kernels/3.10.0-693.2.2.el7.x86_64'

- Andrey

________________________________
From: Jason A. Donenfeld <Jason@zx2c4.com>
Sent: Thursday, October 5, 2017 7:37:53 AM
To: Andrey Petrov
Cc: wireguard@lists.zx2c4.com
Subject: Re: CentOS kernel module build failure

Hey Andrey,

Sorry about that. I fixed it yesterday in the master branch. I'll roll
a new snapshot soon.

https://urldefense.proofpoint.com/v2/url?u=https-3A__git.zx2c4.com_WireGuard_patch_-3Fid-3D24e742617e47bcdb65ba4ce37fa56a107d75d0f3&d=DwIBaQ&c=uilaK90D4TOVoH58JNXRgQ&r=lWprCbBPq-RqvY_cTASTIoLEQCXNtlLeW_TMY-DsKcc&m=S_5FETsVfplUfCEryJzb6i4zFDpq7B5RqIFPinAKNms&s=tX5rcecy9pMG6HvpQ9xgyLoXmUOrwKFDUu4_UlY1X0M&e=

Jason

[-- Attachment #2: Type: text/html, Size: 5965 bytes --]

  reply	other threads:[~2017-10-05  7:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-04 14:03 Andrey Petrov
2017-10-05  4:37 ` Jason A. Donenfeld
2017-10-05  8:12   ` Andrey Petrov [this message]
2017-10-05 13:10     ` Jason A. Donenfeld
2017-10-05 13:22       ` Jason A. Donenfeld

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CY1PR0501MB15797EB039F2510EA00B0303C4700@CY1PR0501MB1579.namprd05.prod.outlook.com \
    --to=apetrov@vmware.com \
    --cc=Jason@zx2c4.com \
    --cc=wireguard@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).