Development discussion of WireGuard
 help / color / mirror / Atom feed
From: Adam Irr <adam.irr@outlook.com>
To: "wireguard@lists.zx2c4.com" <wireguard@lists.zx2c4.com>
Subject: [PATCH] wg-quick: Android: Use ip link to set MTU
Date: Sun, 3 Jan 2021 05:59:19 +0000	[thread overview]
Message-ID: <DM5PR0701MB3670A1B8ADEF9BC7C8E06FEE92D30@DM5PR0701MB3670.namprd07.prod.outlook.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1322 bytes --]

The ndc command used didn't work on my Nvidia Shield (rooted with a custom-built kernel). The ip link command does work. I have only tested this on an Nvidia Shield (Android TV - Version 9.0 Pie).

I couldn't find a lot of documentation on ndc so it's possible my device/kernel is misconfigured. If you suspect this is the case, let me know.

Signed-off-by: Adam Irr <adam.irr@outlook.com>
---
 src/wg-quick/android.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/wg-quick/android.c b/src/wg-quick/android.c
index 326efa9..941c7b8 100644
--- a/src/wg-quick/android.c
+++ b/src/wg-quick/android.c
@@ -995,7 +995,7 @@ static void set_mtu(const char *iface, unsigned int mtu)
        int endpoint_mtu, next_mtu;
 
        if (mtu) {
-               cndc("interface setmtu %s %u", iface, mtu);
+               cmd("ip link set dev %s mtu %d", iface, mtu);
                return;
        }
 
@@ -1016,7 +1016,7 @@ static void set_mtu(const char *iface, unsigned int mtu)
                        endpoint_mtu = next_mtu;
        }
 
-       cndc("interface setmtu %s %d", iface, endpoint_mtu - 80);
+       cmd("ip link set dev %s mtu %d", iface, endpoint_mtu - 80);
 }
 
 static void add_route(const char *iface, unsigned int netid, const char *route)
-- 
2.25.1

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-wg-quick-Android-Use-ip-link-to-set-MTU.patch --]
[-- Type: text/x-patch; name="0001-wg-quick-Android-Use-ip-link-to-set-MTU.patch", Size: 1058 bytes --]

From 1ffa6e6318dbeeaaaf56a916bbaa4994df89b599 Mon Sep 17 00:00:00 2001
From: Adam Irr <adam.irr@outlook.com>
Date: Sat, 2 Jan 2021 21:36:12 -0800
Subject: [PATCH] wg-quick: Android: Use ip link to set MTU

Signed-off-by: Adam Irr <adam.irr@outlook.com>
---
 src/wg-quick/android.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/wg-quick/android.c b/src/wg-quick/android.c
index 326efa9..941c7b8 100644
--- a/src/wg-quick/android.c
+++ b/src/wg-quick/android.c
@@ -995,7 +995,7 @@ static void set_mtu(const char *iface, unsigned int mtu)
 	int endpoint_mtu, next_mtu;
 
 	if (mtu) {
-		cndc("interface setmtu %s %u", iface, mtu);
+		cmd("ip link set dev %s mtu %d", iface, mtu);
 		return;
 	}
 
@@ -1016,7 +1016,7 @@ static void set_mtu(const char *iface, unsigned int mtu)
 			endpoint_mtu = next_mtu;
 	}
 
-	cndc("interface setmtu %s %d", iface, endpoint_mtu - 80);
+	cmd("ip link set dev %s mtu %d", iface, endpoint_mtu - 80);
 }
 
 static void add_route(const char *iface, unsigned int netid, const char *route)
-- 
2.25.1


             reply	other threads:[~2021-01-04 12:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-03  5:59 Adam Irr [this message]
2021-01-04 17:53 ` Harsh Shandilya
2021-01-05  5:50   ` Adam Irr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM5PR0701MB3670A1B8ADEF9BC7C8E06FEE92D30@DM5PR0701MB3670.namprd07.prod.outlook.com \
    --to=adam.irr@outlook.com \
    --cc=wireguard@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).