From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: z <dzm@unexpl0.red>
Cc: wireguard@lists.zx2c4.com, mathias@hall-andersen.dk
Subject: Re: Noise Protocol Question
Date: Thu, 16 Feb 2023 16:39:35 +0100 [thread overview]
Message-ID: <Y+5ONw070fwcUIec@zx2c4.com> (raw)
In-Reply-To: <0685312b-2d0f-495b-b321-80d46326b764@app.fastmail.com>
On Sat, Feb 11, 2023 at 03:39:12PM +0000, z wrote:
> TL;DR Why is wireguard go not calling isZero() on the output of the ECDH key agreement every time?
Good question. AFAICT, this was something I had noticed back when this
code was in development, but then zero checking only got added to the
initiation side, not the response side, in 8c34c4c ("First set of code
review patches"). I don't know whether this was a mistake or if there
was a rationale at the time.
Fortunately, there aren't really any real consequences. But I did fix it
up, so thanks very much for reporting this:
https://git.zx2c4.com/wireguard-go/commit/?id=c7b76d3d9ecdc2ffde80decadda88c0c7cdfeedf
Jason
prev parent reply other threads:[~2023-02-16 15:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-11 15:39 z
2023-02-16 15:39 ` Jason A. Donenfeld [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+5ONw070fwcUIec@zx2c4.com \
--to=jason@zx2c4.com \
--cc=dzm@unexpl0.red \
--cc=mathias@hall-andersen.dk \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).