From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>
Cc: linux-kernel@vger.kernel.org, Martin Liska <mliska@suse.cz>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
wireguard@lists.zx2c4.com, netdev@vger.kernel.org
Subject: Re: [PATCH] wireguard (gcc13): cast enum limits members to int in prints
Date: Mon, 31 Oct 2022 14:07:45 +0100 [thread overview]
Message-ID: <Y1/IoR44xGaVTRUf@zx2c4.com> (raw)
In-Reply-To: <20221031114424.10438-1-jirislaby@kernel.org>
Hi Jiri,
On Mon, Oct 31, 2022 at 12:44:24PM +0100, Jiri Slaby (SUSE) wrote:
> Since gcc13, each member of an enum has the same type as the enum [1]. And
> that is inherited from its members. Provided "REKEY_AFTER_MESSAGES = 1ULL
> << 60", the named type is unsigned long.
>
> This generates warnings with gcc-13:
> error: format '%d' expects argument of type 'int', but argument 6 has type 'long unsigned int'
>
> Cast the enum members to int when printing them.
>
> Alternatively, we can cast it to ulong (to silence gcc < 12) and use %lu.
> Alternatively, we can move REKEY_AFTER_MESSAGES away from the enum.
>
> [1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=36113
Huh, interesting situation. It's interesting that 1<<60 even works at
all on old gccs. I guess that in this case, it just takes the type of
the actual constant, rather than of the enum type?
Either way, I'll apply (a version of) your patch and push it back out on
the next wireguard fixup series.
Thanks for this.
Jason
next prev parent reply other threads:[~2022-10-31 13:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-31 11:44 Jiri Slaby (SUSE)
2022-10-31 13:07 ` Jason A. Donenfeld [this message]
2022-11-01 5:58 ` Jiri Slaby
2022-11-01 9:39 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1/IoR44xGaVTRUf@zx2c4.com \
--to=jason@zx2c4.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jirislaby@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mliska@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).