From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.zx2c4.com (lists.zx2c4.com [165.227.139.114]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4970BC43334 for ; Thu, 30 Jun 2022 17:24:19 +0000 (UTC) Received: by lists.zx2c4.com (OpenSMTPD) with ESMTP id e5b46cb8; Thu, 30 Jun 2022 17:24:17 +0000 (UTC) Received: from ams.source.kernel.org (ams.source.kernel.org [2604:1380:4601:e00::1]) by lists.zx2c4.com (OpenSMTPD) with ESMTPS id 2746697c (TLSv1.2:ECDHE-ECDSA-AES256-GCM-SHA384:256:NO) for ; Thu, 30 Jun 2022 17:24:15 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 46D4CB82CC4; Thu, 30 Jun 2022 17:24:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A18C9C34115; Thu, 30 Jun 2022 17:24:10 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="nYUFivTb" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1656609849; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KqhNJ/uonxDVhq9N5vUXRV4uCAlHxZ8s0M40k+RpZJ0=; b=nYUFivTbayxW5C1Xwhfi8LBwFkEzPR2Ftrki9pRJhiLP13gmPvoZsVareL/wCMsDipYiwO 4JM0NCch9B0KYDriuCFZpfhvdaepv91UEYv5WtB6uyr/ol+Gh3lXWnSAteU4P6FsAT6seG GaipeCKAiYu/WxVhVrJ7xfFACN8YzOo= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 9ff8d2df (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Thu, 30 Jun 2022 17:24:08 +0000 (UTC) Date: Thu, 30 Jun 2022 19:24:04 +0200 From: "Jason A. Donenfeld" To: John Stultz Cc: Kalesh Singh , Christoph Hellwig , Greg Kroah-Hartman , Arve =?utf-8?B?SGrDuG5uZXbDpWc=?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Christian Brauner , Hridya Valsaraju , Suren Baghdasaryan , Theodore Ts'o , "David S. Miller" , Eric Dumazet , Jakub Kicinski , "Alex Xu (Hello71)" , Paolo Abeni , Rob Herring , "Paul E. McKenney" , Frederic Weisbecker , Neeraj Upadhyay , Josh Triplett , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Shuah Khan , LKML , wireguard@lists.zx2c4.com, netdev@vger.kernel.org, rcu , "open list:KERNEL SELFTEST FRAMEWORK" , sultan@kerneltoast.com, android-kernel-team , Saravana Kannan , "Rafael J. Wysocki" Subject: Re: [PATCH] remove CONFIG_ANDROID Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-BeenThere: wireguard@lists.zx2c4.com X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: Development discussion of WireGuard List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: wireguard-bounces@lists.zx2c4.com Sender: "WireGuard" Hi John, On Thu, Jun 30, 2022 at 10:12:30AM -0700, John Stultz wrote: > Does this preference come out of the too-many-options-in-gpg > antipattern? Or is there something else? There are numerous presentations and threads galore on why WireGuard doesn't do knobs. Not worth rehashing here; it's not a bikeshed I really want to have yet again, and I'd appreciate you respecting my time by not going down that route. Sorry. > > Anyway if you don't want a runtime switch, make a compiletime switch > > called CONFIG_PM_CONTINUOUS_RAPID_AUTOSLEEPING or whatever, write some > > very discouraging help text, and call it a day. And this way you don't > > have to worry about ABI and we can change this later on and do the whole > > thing as a no-big-deal change that somebody can tweak later without > > issue. > > Yeah, this is ok with me, as I don't see much benefit to creating a > userland ABI, as I don't think at this point we expect the behavior to > shift or oscillate at runtime. Okay, fine by me. You have my sample patch for this. Feel free to CC me on Gerrit and on the cleaned up patch and I'll offer my acks there. No need to keep this mega thread going longer here. I'll keep my eyes open for Gerrit notifications and such though. Jason