From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Jonathan Corbet <corbet@lwn.net>
Cc: "John Stultz" <jstultz@google.com>,
"Kalesh Singh" <kaleshsingh@google.com>,
"Christoph Hellwig" <hch@lst.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Arve Hjønnevåg" <arve@android.com>,
"Todd Kjos" <tkjos@android.com>,
"Martijn Coenen" <maco@android.com>,
"Joel Fernandes" <joel@joelfernandes.org>,
"Christian Brauner" <brauner@kernel.org>,
"Hridya Valsaraju" <hridya@google.com>,
"Suren Baghdasaryan" <surenb@google.com>,
"Theodore Ts'o" <tytso@mit.edu>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Alex Xu (Hello71)" <alex_y_xu@yahoo.ca>,
"Paolo Abeni" <pabeni@redhat.com>,
"Rob Herring" <robh@kernel.org>,
"Paul E. McKenney" <paulmck@kernel.org>,
"Frederic Weisbecker" <frederic@kernel.org>,
"Neeraj Upadhyay" <quic_neeraju@quicinc.com>,
"Josh Triplett" <josh@joshtriplett.org>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>,
"Lai Jiangshan" <jiangshanlai@gmail.com>,
"Shuah Khan" <shuah@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
wireguard@lists.zx2c4.com, netdev@vger.kernel.org,
rcu <rcu@vger.kernel.org>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
sultan@kerneltoast.com,
android-kernel-team <android-kernel-team@google.com>,
"Saravana Kannan" <saravanak@google.com>,
"Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH] remove CONFIG_ANDROID
Date: Fri, 1 Jul 2022 22:53:36 +0200 [thread overview]
Message-ID: <Yr9e0JnUbu93Qq1p@zx2c4.com> (raw)
In-Reply-To: <87a69slh0x.fsf@meer.lwn.net>
Hi Jon,
On Fri, Jul 01, 2022 at 02:22:38PM -0600, Jonathan Corbet wrote:
> So please forgive the noise from the peanut gallery
Yuh oh, I sure hope this isn't newsworthy for LWN. This has already
consumed me for two days...
> myself wondering...do you really need a knob for this? The kernel
> itself can observe how often (and for how long) the system is suspended,
> and might well be able to do the right thing without explicit input from
> user space. If it works it would eliminate a potential configuration
> problem and also perhaps respond correctly to changing workloads.
>
> For example, rather than testing a knob, avoid resetting keys on resume
> if the suspend time is less than (say) 30s?
>
> Educate me on what I'm missing here, please :)
What you're missing is that wireguard needs to do this before going to
sleep, not when waking up, because one of the objectives is forward
secrecy. See
https://git.zx2c4.com/wireguard-linux/tree/drivers/net/wireguard/device.c#n63
if (IS_ENABLED(CONFIG_PM_AUTOSLEEP) || IS_ENABLED(CONFIG_ANDROID))
return 0;
if (action != PM_HIBERNATION_PREPARE && action != PM_SUSPEND_PREPARE)
return 0;
[...]
wg_noise_handshake_clear(&peer->handshake);
wg_noise_keypairs_clear(&peer->keypairs);
Somebody asked the same question on wgml here -
https://lore.kernel.org/wireguard/CAHmME9p2OYSTX2C5M0faKtw2N8jiyohvRqnAPKa=e7BWynF7fQ@mail.gmail.com/T/
- and then eventually suggested that I should wake up computers from
sleep to clear that memory. No way jose.
Anyway, this matter has been resolved in this thread here:
https://lore.kernel.org/lkml/20220630191230.235306-1-kaleshsingh@google.com/T/
And this Android change:
https://android-review.googlesource.com/c/kernel/common/+/2142693/1
Resulting in these two commits landing in Greg's tree:
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git/commit/?id=261e224d6a5c43e2bb8a07b7662f9b4ec425cfec
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git/commit/?id=1045a06724f322ed61f1ffb994427c7bdbe64647
So hopefully this thread can come to an end and I can get back to work.
Jason
next prev parent reply other threads:[~2022-07-01 20:53 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 15:01 Christoph Hellwig
2022-06-29 15:01 ` [PATCH] " Christoph Hellwig
2022-06-29 15:27 ` Greg Kroah-Hartman
2022-06-29 16:07 ` Paul E. McKenney
2022-06-29 16:09 ` Jason A. Donenfeld
2022-06-29 16:10 ` Christoph Hellwig
2022-06-29 16:13 ` Jason A. Donenfeld
2022-06-29 16:15 ` Christoph Hellwig
2022-06-29 16:25 ` Jason A. Donenfeld
2022-06-29 16:30 ` Christoph Hellwig
2022-06-29 16:38 ` Jason A. Donenfeld
2022-06-29 16:45 ` Christoph Hellwig
2022-06-29 16:52 ` Jason A. Donenfeld
2022-06-29 17:00 ` Greg Kroah-Hartman
2022-06-29 17:10 ` Jason A. Donenfeld
2022-06-29 17:19 ` Greg Kroah-Hartman
2022-06-29 17:30 ` Jason A. Donenfeld
2022-06-29 17:35 ` Christoph Hellwig
2022-06-29 17:42 ` Jason A. Donenfeld
2022-06-29 18:59 ` Paul E. McKenney
2022-06-29 16:56 ` Steven Rostedt
2022-06-29 17:19 ` Jason A. Donenfeld
2022-06-29 17:34 ` Jason A. Donenfeld
2022-06-29 19:05 ` Kalesh Singh
2022-06-29 19:41 ` Theodore Ts'o
2022-06-29 20:47 ` Jason A. Donenfeld
2022-06-29 22:26 ` Kalesh Singh
2022-06-29 23:02 ` Jason A. Donenfeld
2022-06-29 23:19 ` Kalesh Singh
2022-06-30 0:36 ` Joe Perches
2022-06-30 0:50 ` Jason A. Donenfeld
2022-06-30 1:44 ` Joe Perches
2022-06-30 3:02 ` Jason A. Donenfeld
2022-06-29 23:52 ` John Stultz
2022-06-30 0:24 ` Jason A. Donenfeld
2022-06-30 0:30 ` Jason A. Donenfeld
2022-06-30 4:25 ` Kalesh Singh
2022-06-30 10:05 ` Jason A. Donenfeld
2022-06-30 17:12 ` John Stultz
2022-06-30 17:24 ` Jason A. Donenfeld
2022-07-01 20:22 ` Jonathan Corbet
2022-07-01 20:53 ` Jason A. Donenfeld [this message]
2022-06-29 16:34 ` Paul E. McKenney
2022-06-29 16:37 ` Christoph Hellwig
2022-06-29 16:45 ` Jason A. Donenfeld
2022-06-29 17:04 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yr9e0JnUbu93Qq1p@zx2c4.com \
--to=jason@zx2c4.com \
--cc=alex_y_xu@yahoo.ca \
--cc=android-kernel-team@google.com \
--cc=arve@android.com \
--cc=brauner@kernel.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=frederic@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=hridya@google.com \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=jstultz@google.com \
--cc=kaleshsingh@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=maco@android.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paulmck@kernel.org \
--cc=quic_neeraju@quicinc.com \
--cc=rafael@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=robh@kernel.org \
--cc=rostedt@goodmis.org \
--cc=saravanak@google.com \
--cc=shuah@kernel.org \
--cc=sultan@kerneltoast.com \
--cc=surenb@google.com \
--cc=tkjos@android.com \
--cc=tytso@mit.edu \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).