From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Michael Pro <michael.adm@gmail.com>
Cc: wireguard@lists.zx2c4.com, kevans@freebsd.org
Subject: Re: FreeBSD current socket-src changed. Wireguard not compiling.
Date: Mon, 29 Aug 2022 12:16:35 -0400 [thread overview]
Message-ID: <YwzmY6Q/lJIDZyfz@zx2c4.com> (raw)
In-Reply-To: <CAA+Mow79-=J1LmFWdFOEnVnV4QCKyWb13YsvzOrsxtWV=GgJ7A@mail.gmail.com>
On Tue, Aug 23, 2022 at 12:26:21PM +0300, Michael Pro wrote:
> Tonight after updating kernel freebsd current I got coredump with
> wireguard enabled kernel module.
>
> As is
> https://reviews.freebsd.org/D36232
> D36232 protosw: refactor protosw and domain static declaration and
> load (freebsd.org)
> in wireguard-freebsd/src/support.h
> ...
> error = (*so->so_proto->pr_usrreqs->pru_sockaddr)(so, nam);
> ...
> replace to
> ...
> error = solisten_proto_check(so);
> ...
> Recompile - no more core dumps. All works now, perhaps...
>
> Is this the right way to fix the problem? Is this enough or should we
> wait for a full-scale refactoring of the code?
>
> Thanks in advance for your reply.
Thanks. Is there a __FreeBSD_version__ change that corresponds?
Jason
next prev parent reply other threads:[~2022-08-29 16:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 9:26 Michael Pro
2022-08-29 16:16 ` Jason A. Donenfeld [this message]
2022-08-31 18:18 ` Ed Maste
2022-09-01 5:40 ` Michael Pro
2022-09-04 17:07 ` Jason A. Donenfeld
2022-09-04 17:20 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwzmY6Q/lJIDZyfz@zx2c4.com \
--to=jason@zx2c4.com \
--cc=kevans@freebsd.org \
--cc=michael.adm@gmail.com \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).