* [PATCHv2 net] selftests: wireguard: load nf_conntrack if it's not present
@ 2024-11-12 9:48 Hangbin Liu
2024-11-13 9:48 ` Simon Horman
2024-11-17 20:11 ` Jason A. Donenfeld
0 siblings, 2 replies; 3+ messages in thread
From: Hangbin Liu @ 2024-11-12 9:48 UTC (permalink / raw)
To: netdev
Cc: Jason A. Donenfeld, Shuah Khan, David S. Miller, Simon Horman,
wireguard, linux-kselftest, linux-kernel, Hangbin Liu
Some distros may not load nf_conntrack by default, which will cause
subsequent nf_conntrack settings to fail. Let's load this module if it's
not loaded by default.
Fixes: e7096c131e51 ("net: WireGuard secure network tunnel")
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
---
v2: load the mode directly in case nf_conntrack is build in (Simon Horman)
---
tools/testing/selftests/wireguard/netns.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/wireguard/netns.sh b/tools/testing/selftests/wireguard/netns.sh
index 405ff262ca93..fa4dd7eb5918 100755
--- a/tools/testing/selftests/wireguard/netns.sh
+++ b/tools/testing/selftests/wireguard/netns.sh
@@ -66,6 +66,7 @@ cleanup() {
orig_message_cost="$(< /proc/sys/net/core/message_cost)"
trap cleanup EXIT
printf 0 > /proc/sys/net/core/message_cost
+modprobe nf_conntrack
ip netns del $netns0 2>/dev/null || true
ip netns del $netns1 2>/dev/null || true
--
2.39.5 (Apple Git-154)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCHv2 net] selftests: wireguard: load nf_conntrack if it's not present
2024-11-12 9:48 [PATCHv2 net] selftests: wireguard: load nf_conntrack if it's not present Hangbin Liu
@ 2024-11-13 9:48 ` Simon Horman
2024-11-17 20:11 ` Jason A. Donenfeld
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2024-11-13 9:48 UTC (permalink / raw)
To: Hangbin Liu
Cc: netdev, Jason A. Donenfeld, Shuah Khan, David S. Miller,
wireguard, linux-kselftest, linux-kernel
On Tue, Nov 12, 2024 at 09:48:27AM +0000, Hangbin Liu wrote:
> Some distros may not load nf_conntrack by default, which will cause
> subsequent nf_conntrack settings to fail. Let's load this module if it's
> not loaded by default.
>
> Fixes: e7096c131e51 ("net: WireGuard secure network tunnel")
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
> ---
> v2: load the mode directly in case nf_conntrack is build in (Simon Horman)
Thanks for the update.
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCHv2 net] selftests: wireguard: load nf_conntrack if it's not present
2024-11-12 9:48 [PATCHv2 net] selftests: wireguard: load nf_conntrack if it's not present Hangbin Liu
2024-11-13 9:48 ` Simon Horman
@ 2024-11-17 20:11 ` Jason A. Donenfeld
1 sibling, 0 replies; 3+ messages in thread
From: Jason A. Donenfeld @ 2024-11-17 20:11 UTC (permalink / raw)
To: Hangbin Liu
Cc: netdev, Shuah Khan, David S. Miller, Simon Horman, wireguard,
linux-kselftest, linux-kernel
On Tue, Nov 12, 2024 at 09:48:27AM +0000, Hangbin Liu wrote:
> Some distros may not load nf_conntrack by default, which will cause
> subsequent nf_conntrack settings to fail. Let's load this module if it's
> not loaded by default.
>
> Fixes: e7096c131e51 ("net: WireGuard secure network tunnel")
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-11-18 4:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-11-12 9:48 [PATCHv2 net] selftests: wireguard: load nf_conntrack if it's not present Hangbin Liu
2024-11-13 9:48 ` Simon Horman
2024-11-17 20:11 ` Jason A. Donenfeld
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).