From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: simon@ruderich.org Received: from krantz.zx2c4.com (localhost [127.0.0.1]) by krantz.zx2c4.com (ZX2C4 Mail Server) with ESMTP id 00d9035e for ; Mon, 1 Jan 2018 10:52:03 +0000 (UTC) Received: from zucker2.schokokeks.org (zucker2.schokokeks.org [178.63.68.90]) by krantz.zx2c4.com (ZX2C4 Mail Server) with ESMTP id c0c6309e for ; Mon, 1 Jan 2018 10:51:57 +0000 (UTC) From: Simon Ruderich To: wireguard@lists.zx2c4.com Subject: [PATCH 07/12] peer: NewPeer(): add missing device.mutex.Unlock() in error paths Date: Mon, 1 Jan 2018 11:52:57 +0100 Message-Id: In-Reply-To: References: In-Reply-To: References: List-Id: Development discussion of WireGuard List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , --- src/peer.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/peer.go b/src/peer.go index 228fe73..244bae0 100644 --- a/src/peer.go +++ b/src/peer.go @@ -83,6 +83,7 @@ func (device *Device) NewPeer(pk NoisePublicKey) (*Peer, error) { // check if over limit if len(device.peers) >= MaxPeers { + device.mutex.Unlock() return nil, errors.New("Too many peers") } @@ -90,6 +91,7 @@ func (device *Device) NewPeer(pk NoisePublicKey) (*Peer, error) { _, ok := device.peers[pk] if ok { + device.mutex.Unlock() return nil, errors.New("Adding existing peer") } device.peers[pk] = peer -- 2.15.1