From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C45EC433FE for ; Sun, 13 Dec 2020 15:38:39 +0000 (UTC) Received: from krantz.zx2c4.com (krantz.zx2c4.com [192.95.5.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4B5FA230FF for ; Sun, 13 Dec 2020 15:38:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4B5FA230FF Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=urlichs.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=wireguard-bounces@lists.zx2c4.com Received: by krantz.zx2c4.com (ZX2C4 Mail Server) with ESMTP id f130e3ec; Sun, 13 Dec 2020 15:30:09 +0000 (UTC) Received: from netz.smurf.noris.de (dispatch.smurf.noris.de [2001:780:107:b::b]) by krantz.zx2c4.com (ZX2C4 Mail Server) with ESMTPS id 0a4293cf (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Sun, 13 Dec 2020 15:30:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=urlichs.de; s=20160512; h=Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:Subject: Cc:From:References:To:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=LJWXCEfxtI2qDeR9POKxoNUdzhb5BH2bTWUe2QtE1lM=; b=aR//YVsVdq12wxfympYi3GfKQE GGp0DR743GDZYoYwXKavhPnN5dqpZCpLVX+xD9uGPEZ3fYpg6Vss7demctLh+mNSvp0ou9vJSksZO Bm1bTJlA+5bSB+xHbXz6f1vy/jrOu1luyp+ttObAGlM5Z0+Ll3I4HhRVuqpVGkYjQM8PAkPFEVPz+ ttPIpX5piIClNVfzgL+no2zlJjcUKzeOnUGBI9mLMbZZv/BrI21JymOYYSpmT14IAJqrg2Op6Zakv +ktVDLNrRvp3qsDCLs/IHX8y1r+pnkpGdxTrqPituHLWJegB+X2bR/Cil+0sSNdn6pca7YBjfyIs3 4+r5a8taN1sGLqAPAxtTEX5+MVRNR2B/JoagcoWyclyt7sOXYMpML+XYjAc5v8/H63Q2KL08Dhbiz VuEtQelaYvFYASrBjkQE5lk0dZqPgYwCLfVg0he21btNOtVrpkN6O4g5qpbJZq+IsflHuv2bFL5rZ oAIgNosJ9NKpSsglpThWhfm/WLxPT/oH+SXfJ4wG8Q+VvNERkZaq51MdZ1l29w5D8hCb+VQu7dxBc S43FUHOrc1Ff6ue12UnN1YDfVggDWfSoEbpA6gVrrQWD5Ojryn31LoL3p8EUDznZKLP0SXIoZHv/4 nh+yWdBMCyVLP41wph2gBGr+je4+ibLl9WU6BAPQ8=; Received: from asi.s.smurf.noris.de ([2001:780:107:200::a]) by mail.vm.smurf.noris.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1koTRI-000BBG-93; Sun, 13 Dec 2020 16:37:36 +0100 To: Miguel Ojeda , Greg KH References: <20201128193335.219395-1-masahiroy@kernel.org> <20201212161831.GA28098@roeck-us.net> <8f645b94-80e5-529c-7b6a-d9b8d8c9685e@roeck-us.net> From: Matthias Urlichs Cc: Guenter Roeck , Masahiro Yamada , "Jason A . Donenfeld" , Nathan Chancellor , Nick Desaulniers , Shuah Khan , clang-built-linux , linux-kernel , "open list:KERNEL SELFTEST FRAMEWORK" , Network Development , wireguard@lists.zx2c4.com Subject: Re: [PATCH v3] Compiler Attributes: remove CONFIG_ENABLE_MUST_CHECK Message-ID: Date: Sun, 13 Dec 2020 16:37:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <8f645b94-80e5-529c-7b6a-d9b8d8c9685e@roeck-us.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="0bdZizaKkR1RRcy81CAwRurahlx0BShKc" X-Smurf-Spam-Score: 0.0 (/) X-BeenThere: wireguard@lists.zx2c4.com X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: Development discussion of WireGuard List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: wireguard-bounces@lists.zx2c4.com Sender: "WireGuard" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --0bdZizaKkR1RRcy81CAwRurahlx0BShKc Content-Type: multipart/mixed; boundary="UUmMppQ0TtM1nbyb9GJXrF53J0jYOCzmm"; protected-headers="v1" From: Matthias Urlichs To: Miguel Ojeda , Greg KH Cc: Guenter Roeck , Masahiro Yamada , "Jason A . Donenfeld" , Nathan Chancellor , Nick Desaulniers , Shuah Khan , clang-built-linux , linux-kernel , "open list:KERNEL SELFTEST FRAMEWORK" , Network Development , wireguard@lists.zx2c4.com Message-ID: Subject: Re: [PATCH v3] Compiler Attributes: remove CONFIG_ENABLE_MUST_CHECK References: <20201128193335.219395-1-masahiroy@kernel.org> <20201212161831.GA28098@roeck-us.net> <8f645b94-80e5-529c-7b6a-d9b8d8c9685e@roeck-us.net> In-Reply-To: <8f645b94-80e5-529c-7b6a-d9b8d8c9685e@roeck-us.net> --UUmMppQ0TtM1nbyb9GJXrF53J0jYOCzmm Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: de-DE Miguel Ojeda wrote: > I think we can fix them as they come. If your change to a function breaks its callers, it's your job to fix=20 the callers proactively instead of waiting for "as they come" bug=20 reports. (Assuming, of course, that you know about the breakage. Which=20 you do when you tell us that the bad pattern can simply be grepped for.) If nothing else, that's far more efficient than [number_of_callers]=20 separate patches by other people who each need to find the offending=20 change, figure out what to change and/or who to report the problem to,=20 and so on until the fix lands in the kernel. Moreover, this wouldn't leave the kernel sources in a non-bisect-able=20 state during that time. --=20 -- Matthias Urlichs --UUmMppQ0TtM1nbyb9GJXrF53J0jYOCzmm-- --0bdZizaKkR1RRcy81CAwRurahlx0BShKc Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsF5BAABCAAjFiEENzGcEL8EYxehRDgJ+GyybHbBwWUFAl/WNT8FAwAAAAAACgkQ+GyybHbBwWWQ /Q/5Admk46b0U6/UaWBUvAy/2onXR+LSpg8kaKfHNHgWtiBlVCLskfttGkO7vkAlF7chabDO425F JIa+zZmAelvHYTsKXba5xLmuX4CyA/tUUgBJH5l4f31Ywev0NyOd/tHaXstN1YgCXRNuiVLPrMU2 nAIhS2F+cX37C6jl8SayIy8+PKfSUR3sshRnIceEW8cTeqvnogGxr++UJKE8ShUTdgg4BVqIvJ6r K39mfn/kAFtVQ9aT5vFHuvJJDUn+el4fQlkID77uWgIPBHqEBUuQQkxV3JCWH8rdgKXlowdlqHWU m7ID6nhnJy0h+GfZTJhj1MQuO92M2lRq5x1aeQMP2EVp3n+fIzrjharn1CJerFRuv7aymt+QF8ZH EUga+0tMg+DFGsQaQcFbyWwflluKj6++KSH69Bfh7ZFxop9X4v1aPO1GALUymM4CwcC9KO2hpMG9 q0iZWUu/nw7yJo30b8wrjQykL0xRonbrHYrkhbMy1v6DsZdvk4wdsuQUu76OSs+eYzY9VZv9vLKE LOHQiHjKRndnm871eDFw0W17avE6MxLlMRaW6Qk1YnkTuuywih8XFdddTJuuMf0eFU/GdYbyo6Pa rmiaTWPRHvwVYYq5h8jrnDSz1TpZGqSFcfE+2ZtLu3bUfj+NsGymwUI4/IegRlmkJ6uaEd7p4rB+ SUM= =vTgV -----END PGP SIGNATURE----- --0bdZizaKkR1RRcy81CAwRurahlx0BShKc--