From: David Woodhouse <dwmw2@infradead.org>
To: Simon Rozman <simon@rozman.si>, Daniel Lenski <dlenski@gmail.com>
Cc: WireGuard mailing list <wireguard@lists.zx2c4.com>
Subject: Re: Allowing space for packet headers in Wintun Tx/Rx
Date: Sat, 10 Apr 2021 15:35:28 +0100 [thread overview]
Message-ID: <fb3e80d74068cd8464c44f1cb435b71d1170c659.camel@infradead.org> (raw)
In-Reply-To: <a1bee48639cb40299118c53d4fa8fe7a@rozman.si>
[-- Attachment #1: Type: text/plain, Size: 981 bytes --]
On Sat, 2021-04-10 at 13:38 +0000, Simon Rozman wrote:
> Hi David,This is my proposal:
> https://git.zx2c4.com/wintun/commit/?id=eebd6aea4f75551f6e847a1d4fff857450bac6e9
> Awaiting review and zx2c4 approval. 😊
> Regards, Simon
Looks good to me; thanks. Just need to work out how to cross-build it
(I can muster up a Windows VM for testing, but *building* on it is
beyond my tolerance of Windows for now).
We'll also need to be able to WintunAllocateSendPacket() of the full
possible MTU, then receive and decrypt into that, and send only the
actual size of the packet we received.
A per-packet tail would have let us do that, but I agree that we don't
want to expand the TUN_PACKET header if we can avoid doing so.
Perhaps a WintunShrinkAndSendPacket() — which can only *shrink*, of
course, and which can only be used on the *last* packet allocated,
checking that its tail *is* the Session->Receive.Tail before adjusting
the latter accordingly.
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5174 bytes --]
next prev parent reply other threads:[~2021-04-10 14:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 11:49 David Woodhouse
2021-04-07 23:15 ` Daniel Lenski
2021-04-08 14:37 ` David Woodhouse
2021-04-08 16:42 ` Daniel Lenski
2021-04-08 17:10 ` David Woodhouse
2021-04-08 17:37 ` Daniel Lenski
2021-04-10 13:38 ` Simon Rozman
2021-04-10 14:35 ` David Woodhouse [this message]
2021-04-10 18:32 ` Daniel Lenski
2021-04-12 11:38 ` Simon Rozman
2021-04-12 13:00 ` David Woodhouse
2021-04-12 17:03 ` Jason A. Donenfeld
2021-04-13 22:09 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb3e80d74068cd8464c44f1cb435b71d1170c659.camel@infradead.org \
--to=dwmw2@infradead.org \
--cc=dlenski@gmail.com \
--cc=simon@rozman.si \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).