From: Eryk Wieliczko <eryk@wieliczko.ninja>
To: "noloader@gmail.com" <noloader@gmail.com>
Cc: "wireguard@lists.zx2c4.com" <wireguard@lists.zx2c4.com>
Subject: Re: DNS name resolution should not be done during configuration parsing.
Date: Sun, 17 Feb 2019 13:15:07 +0000 [thread overview]
Message-ID: <qtitL38P5VIptTV36IWKsoa4vWvlZyqhe3DFCyki22NSub1EVaaRJAg0NAKtFYKi68OwXXPKJH_firCbnX-X2-UCuFsKhruaQueFmouHj3k=@wieliczko.ninja> (raw)
In-Reply-To: <CAH8yC8nz5wwL=xKipUwUtrMqQJ5fHcWAdwzrMpX0Hxck+gO0kQ@mail.gmail.com>
You are right, I got confused.
I thought that this would be something that _the user_ would have to set up. Please forgive my ignorance. :-)
Since these scripts are installed by WG and not by a user, this solution would be fine.
Isn't it the case that currently WG is performing DNS both during configuration AND during connection setup? I see that there is _getaddrinfo_ in ipc.c...
Maybe just removing all getaddrinfo from config.c would be enough to fix this?
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Sunday, February 17, 2019 2:07 PM, Jeffrey Walton <noloader@gmail.com> wrote:
> On Sun, Feb 17, 2019 at 7:40 AM Eryk Wieliczko eryk@wieliczko.ninja wrote:
>
> > > Forgive my ignorance... Should init just retry the service start?
> > > Something like this (from Systemd):
> > > [Unit]
> > > StartLimitInterval=360
> > > StartLimitBurst=5
> > > The statements above say to retry 5 times within 360 seconds.
> > > Configuring such things is an additional unnecessary step. OpenVPN/tinc don't require such hacks. Once you start OpenVPN, it's gonna work until the server dies of old age. :-)
>
> I have to admit I don't quite understand calling it "unnecessary".
>
> There seems to be two use cases (maybe more?): manual start and auto
> start. The auto start case is usually handled by init scripts. Init
> scripts usually retry.
>
> I'm not throwing stones, but I have to ask... Why not use the tools
> available instead of adding hacks on top of hacks? The hacks likely
> make the code brittle. By the time Wiregaurd gets to supporting AIX,
> Dragonfly, Hurd, Solaris and other Unix personalities no one will want
> to touch it.
>
> Jeff
_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard
next prev parent reply other threads:[~2019-02-18 23:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 22:28 Eryk Wieliczko
2019-02-17 3:03 ` David Kerr
2019-02-17 4:08 ` Jeffrey Walton
2019-02-17 12:40 ` Eryk Wieliczko
2019-02-17 13:07 ` Jeffrey Walton
2019-02-17 13:15 ` Eryk Wieliczko [this message]
2019-02-19 3:01 ` zrm
2019-02-19 7:22 ` Matthias Urlichs
2019-02-19 14:26 ` Lonnie Abelbeck
2019-02-19 15:45 ` Vincent Wiemann
2019-02-21 7:59 ` Matthias Urlichs
2019-02-22 1:29 ` Vincent Wiemann
2019-02-19 14:58 ` David Kerr
2019-02-17 12:47 ` Eryk Wieliczko
2019-02-17 18:26 ` Vincent Wiemann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='qtitL38P5VIptTV36IWKsoa4vWvlZyqhe3DFCyki22NSub1EVaaRJAg0NAKtFYKi68OwXXPKJH_firCbnX-X2-UCuFsKhruaQueFmouHj3k=@wieliczko.ninja' \
--to=eryk@wieliczko.ninja \
--cc=noloader@gmail.com \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).