From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13427 invoked from network); 12 Apr 2004 15:22:05 -0000 Received: from sunsite.dk (130.225.247.90) by ns1.primenet.com.au with SMTP; 12 Apr 2004 15:22:05 -0000 Received: (qmail 16116 invoked by alias); 12 Apr 2004 15:21:26 -0000 Mailing-List: contact zsh-users-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 7336 Received: (qmail 16085 invoked from network); 12 Apr 2004 15:21:26 -0000 Received: from localhost (HELO sunsite.dk) (127.0.0.1) by localhost with SMTP; 12 Apr 2004 15:21:26 -0000 X-MessageWall-Score: 0 (sunsite.dk) Received: from [130.225.247.86] by sunsite.dk (MessageWall 1.0.8) with SMTP; 12 Apr 2004 15:21:25 -0000 Received: (qmail 7381 invoked from network); 12 Apr 2004 15:21:25 -0000 Received: from wbar3.sjo1-4-11-009-147.sjo1.dsl-verizon.net (HELO candle.brasslantern.com) (4.11.9.147) by a.mx.sunsite.dk with SMTP; 12 Apr 2004 15:21:22 -0000 Received: (from schaefer@localhost) by candle.brasslantern.com (8.11.6/8.11.6) id i3CFLKw19015 for zsh-users@sunsite.dk; Mon, 12 Apr 2004 08:21:20 -0700 From: Bart Schaefer Message-Id: <040412082120.ZM19014@candle.brasslantern.com> Date: Mon, 12 Apr 2004 08:21:20 -0700 In-Reply-To: <20040412090436.GC28460@blorf.net> Comments: In reply to Wayne Davison "Re: zle_thingy.c: variable "modsave" used before its value set" (Apr 12, 2:04am) References: <1087.1079112181@csr.com> <20040412090436.GC28460@blorf.net> X-Mailer: Z-Mail Lite (5.0.0 30July97) To: Zsh users list Subject: Re: zle_thingy.c: variable "modsave" used before its value set MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Checker-Version: SpamAssassin 2.63 on a.mx.sunsite.dk X-Spam-Level: **** X-Spam-Status: No, hits=4.7 required=6.0 tests=RCVD_IN_DYNABLOCK, RCVD_IN_NJABL,RCVD_IN_NJABL_DIALUP,RCVD_IN_SORBS autolearn=no version=2.63 X-Spam-Hits: 4.7 On Apr 12, 2:04am, Wayne Davison wrote: > > The variable can't actually be used uninitialized -- the compiler just > thinks it can. > > If we want to get rid of the warning, I'd recommend making the struct > static rather than initializing it to an unneeded value on every call. Are you really sure that bin_zle_call() is not re-entrant? Seems to me that the whole point of modsave is that it is a stack variable.