From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-users@sunsite.dk
Subject: Re: Installing zsh-4.3.1
Date: Thu, 02 Mar 2006 22:01:48 -0800 [thread overview]
Message-ID: <060302220150.ZM20277@torch.brasslantern.com> (raw)
In-Reply-To: <0dc952111d6c7539ef19f7ef2331db46@gmail.com>
On Mar 1, 8:42am, FX Coudert wrote:
}
} 1. the make process doesn't support parallel building.
This has been noted a number of times dating back at least to three
years ago. One problem (as Wayne observed then) is with the "prep"
target, which the structure of the generated Makefile/Makemod files
falsely indicates can be built in parallel with some other targets
that, in reality, depend upon "prep" having completed first.
The following minimal patch fixes this to the first order. I'm a
little concerned that it will break something in the case where
"make -f Makemod prep" would fail, because Makemod is then created
by "make Makemod" but removed by "make prep".
Index: Src/Makefile.in
===================================================================
retrieving revision 1.6
diff -c -r1.6 Src/Makefile.in
--- Src/Makefile.in 24 Sep 2005 17:48:35 -0000 1.6
+++ Src/Makefile.in 3 Mar 2006 05:27:19 -0000
@@ -109,7 +109,7 @@
@CONFIG_MK@
-Makemod prep: $(CONFIG_INCS) $(dir_top)/config.modules
+Makemod: $(CONFIG_INCS) $(dir_top)/config.modules
@case $(sdir_top) in \
/*) top_srcdir=$(sdir_top) ;; \
*) top_srcdir=$(subdir)/$(sdir_top) ;; \
@@ -119,6 +119,7 @@
'$$top_srcdir/$(subdir)/mkmakemod.sh $(subdir) Makemod'; \
cd $(dir_top) && \
$(SHELL) $$top_srcdir/$(subdir)/mkmakemod.sh $(subdir) Makemod
+prep: Makemod
@$(MAKE) -f Makemod $(MAKEDEFS) prep || rm -f Makemod
.PHONY: prep
However, there is yet another problem, which is that several targets in
Makefile are built by invoking "make -f Makemod", and Makemod itself is
not re-entrant. This seems mainly to be because of zsh.mdd, which
contains instructions for making signames.c and sigcount.h. I think
those rules should be moved out of zsh.mdd and into Makefile.in, but
perhaps there's another way to get them pre-built.
--
prev parent reply other threads:[~2006-03-03 6:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-01 7:42 FX Coudert
2006-03-03 6:01 ` Bart Schaefer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=060302220150.ZM20277@torch.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=zsh-users@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).