From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: zsh-users-return-23646-ml=inbox.vuxu.org@zsh.org
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI,
	RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2
Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2])
	by inbox.vuxu.org (OpenSMTPD) with ESMTP id 69740b4d
	for <ml@inbox.vuxu.org>;
	Mon, 17 Sep 2018 16:31:16 +0000 (UTC)
Received: (qmail 24043 invoked by alias); 17 Sep 2018 16:30:59 -0000
Mailing-List: contact zsh-users-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Users List <zsh-users.zsh.org>
List-Post: <mailto:zsh-users@zsh.org>
List-Help: <mailto:zsh-users-help@zsh.org>
List-Unsubscribe: <mailto:zsh-users-unsubscribe@zsh.org>
X-Seq: 23646
Received: (qmail 25059 invoked by uid 1010); 17 Sep 2018 16:30:59 -0000
X-Qmail-Scanner-Diagnostics: from forward104p.mail.yandex.net by f.primenet.com.au (envelope-from <zsh@mva.name>, uid 7791) with qmail-scanner-2.11 
 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1.  
 Clear:RC:0(77.88.28.107):SA:0(-2.6/5.0):. 
 Processed in 2.768605 secs); 17 Sep 2018 16:30:59 -0000
X-Envelope-From: zsh@mva.name
X-Qmail-Scanner-Mime-Attachments: |
X-Qmail-Scanner-Zip-Files: |
X-Yandex-Suid-Status: 1 0
From: "Vadim A. Misbakh-Soloviov" <zsh@mva.name>
To: zsh-users@zsh.org
Subject: [BUG] adb completion skips devices from serial number completion if they don't report 'product' field in "... devices -l"
Date: Mon, 17 Sep 2018 23:23:15 +0700
Message-ID: <10113172.57ZNmLz3PP@tp>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="UTF-8"

Hi there!

I've faced a pretty sad bug: if, for a some reason, device doesn't report 
'product' field in `adb devices -l` listing, it will be skipped from `adb -s` 
completion.

For example:

$  adb devices -l
List of devices attached
192.168.0.134:5555     device transport_id:681
192.168.0.111:5555     device product:polaris_a70H model:N8000 device:polaris-
a70H transport_id:680
riki:5555              device product:rk30sdk model:ES9701 device:rk30sdk 
transport_id:679
pola:5555              device product:polaris_a70H model:N8000 device:polaris-
a70H transport_id:678
crane:5555             device transport_id:676
192.168.0.69:5555      offline transport_id:671
192.168.0.57:5555      device product:rk30sdk model:ES9701 device:rk30sdk 
transport_id:670

$ adb -s 192.168.0.111
 available devices
192.168.0.111  pola  -- 5555:polaris_a70H
192.168.0.57   riki  -- 5555:rk30sdk

As you can see, it misses the `crane` (and *.134) device in completion, 
although it is definitelly not offline (and I can run adb against it if I 
manually specify it to `-s`.