zsh-users
 help / color / mirror / code / Atom feed
From: "Bart Schaefer" <schaefer@brasslantern.com>
To: Zsh users list <zsh-users@sunsite.dk>
Subject: Re: check for existence without full globbing
Date: Tue, 4 Feb 2003 05:16:23 +0000	[thread overview]
Message-ID: <1030204051624.ZM15383@candle.brasslantern.com> (raw)
In-Reply-To: <20030204032905.15019.qmail@web12308.mail.yahoo.com>

On Feb 3, 10:29pm, Le Wang wrote:
}
} I need to get a list of directories that have .java files in them.  Here is
} the snipplet:
} 
} for i ( $sourcePath ) {
}   for j ( $i/**/*(-/) ) {

The (-) qualifier there probably doesn't do what you think.  **/ won't
descend through symlinks, so **/*(-/) will not descend beyond the first
symlink in any path.  Hence you'll only find the .java files that are
directly within the symlinked directories, not those in any subdirs of
the symlinked directories, if you see what I mean.

If you can be sure the symlinks don't cycle, you can use ***/ instead.

}     setopt localoptions
}     setopt nullglob
}     unsetopt globsubst
}     tempArr=( $j/*.java )
} 
}     if (( $#tempArr >= 1 )); then
}       temp=${j#$i/}
}       temp=${temp//\\//.}
}       packages=( $packages $temp )
}     fi
}   }
} }
} 
} It was taking quite a while to glob through all the .java files.

I'll bet it's taking much longer to do the ${j#$/} ${temp//\\//.} stuff,
plus packages=( $packages $temp ), in a loop, than to do the globbing.
And you should almost never put setopt/unsetopt commands inside a loop
body, because they don't revert at the end of the loop (only at the end
of a shell function), so all you're doing every time around is resetting
something that's already set.

Try this and see if it's faster:

    typeset -U packages
    packages=( ${~~^sourcePath}/./**/*(N-/) )
    packages=( ${~~^packages}/**/*.java(N:h) )
    packages=( ${${~~packages##*/./}:gs,/,.} )

The double tildes in ${~~...} turn off globsubst for that expansion, and
the N turns on nullglob, so you don't have to mess around with setopt.

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com

Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net   


  reply	other threads:[~2003-02-04  5:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-02-03 21:24 Le Wang
2003-02-04  2:49 ` Bart Schaefer
2003-02-04  3:29   ` Le Wang
2003-02-04  5:16     ` Bart Schaefer [this message]
2003-02-04  9:38       ` John Buttery
2003-02-04 18:01         ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1030204051624.ZM15383@candle.brasslantern.com \
    --to=schaefer@brasslantern.com \
    --cc=zsh-users@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).