From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 30151 invoked from network); 13 May 2021 16:09:34 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 13 May 2021 16:09:34 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20200801; t=1620922174; b=ZIKOEh2hjRRykMWomToQmngmeTU0EZoCNd4bTdrlEZjvGLJbTE8RCequ/XQhEQURR4wsxGOL2p Orl77IsGEdQm7FCQWVLtY4irYnvw23gw3P4rNO0VksFuQJpbuBdljXv9FZKjq9HGgHs5m19XY9 ToF1bZQml8IWkn/GtENpXDvjzD9nClR5vuUo3u8oLwuGvQ+btnOGnQf0y2BtVpPYJxqsrTqcAq LsqsLj/6rWJfD4P7OIbZ6Tv5C0O/ZaIfScvz0+eIwv5v77YzWakpurUKcMH1JaLvrRIEjAsiCg kuIs4+KlkMtk/MqKAUHTQJ5dSuECEMW/5ggZQdgs5gkZag==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (smtpq1.tb.ukmail.iss.as9143.net) smtp.remote-ip=212.54.57.96; dkim=pass header.d=ntlworld.com header.s=meg.feb2017 header.a=rsa-sha256; dmarc=pass header.from=ntlworld.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20200801; t=1620922174; bh=94eNkvGValCP3eI3rt2EFGZ+sGnb2glVVxPAwb1xMfo=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject: References:In-Reply-To:Message-ID:Cc:To:From:Date:DKIM-Signature: DKIM-Signature; b=NDNvG8xroEdmYIr5tCO8tqcJvDHc2U8js2u4F1B7T1Xjk/GNKg0lyfrUEJDHuGA757K74XFbk2 9O/gzjqS8NYEympLwslWa+ijwOStZlDbwWvMTow3o0T6hTGHykTQvIUD3wKkwqCtkOKS4hxfXL b0h1xHD9hHr2xufny8dZrNGKqVBXZ3NvNO5kOwYaPxXq4a9IY+3cos7hHJPU/Kwvoyauc/7lvX +UKV6r2BpItwDg8FZ2vqzfuqlJvgf8AFj8yjo8BR+H9nzI3hpgVdX88iCLi+kIS908C9YSm5Z1 p4OOaZGXCKzWoRi49wy+BQxhg4afJGXNwxMqxQf2nTdR6g==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:Subject:References:In-Reply-To:Message-ID:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=wZBSfzrZ4kVpbQ4Ylt3Hy1kkC9CUXj3YsZISX4OvJ5c=; b=pVu9M3cJL9ocWplzU8qhcXQ/DQ /6DSD2HtAsDo6TAjTPW96ONb2cHYMXSP4vK/mkmAZ08GAbvFaudXXL/HpgnKqqjjhFr1QaNLx5Khf vL6eE9Gznbowp36vMHZf1tcYxnvt8kWV1oCMhPOQonnzKwf7ps/Omm/xW+jPrgm6pPdKNO1dJs2Rl No8MENwEH8cGr6crdTmWoreI0gyyX6NvgmUcaJVnTsvEfj9kkgbuF8gXci2hhTGuTFR39rIQYGwJH vHtJai8HHj5LYU8gA67SmczrBJqorassdKculVu/+8feOn/P3CgzdBkv/VaMd4il9dbzFC1H1YM5F Q6Xu0F2A==; Received: from authenticated user by zero.zsh.org with local id 1lhDu1-0000Y7-VU; Thu, 13 May 2021 16:09:33 +0000 Authentication-Results: zsh.org; iprev=pass (smtpq1.tb.ukmail.iss.as9143.net) smtp.remote-ip=212.54.57.96; dkim=pass header.d=ntlworld.com header.s=meg.feb2017 header.a=rsa-sha256; dmarc=pass header.from=ntlworld.com; arc=none Received: from smtpq1.tb.ukmail.iss.as9143.net ([212.54.57.96]:59024) by zero.zsh.org with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) id 1lhDri-000Pkv-KC; Thu, 13 May 2021 16:07:11 +0000 Received: from [212.54.57.82] (helo=smtp3.tb.ukmail.iss.as9143.net) by smtpq1.tb.ukmail.iss.as9143.net with esmtp (Exim 4.86_2) (envelope-from ) id 1lhDri-0005Ac-E7 for zsh-users@zsh.org; Thu, 13 May 2021 18:07:10 +0200 Received: from oxbe8.tb.ukmail.iss.as9143.net ([172.25.160.139]) by smtp3.tb.ukmail.iss.as9143.net with ESMTP id hDril97rNMu5ghDrilE3Nd; Thu, 13 May 2021 18:07:10 +0200 X-Env-Mailfrom: p.w.stephenson@ntlworld.com X-Env-Rcptto: zsh-users@zsh.org X-SourceIP: 172.25.160.139 X-CNFS-Analysis: v=2.4 cv=FZNUeLy6 c=1 sm=1 tr=0 ts=609d4eae cx=a_exe a=pgSR3NrKiwmx/6vnWRL19w==:117 a=jjcMUZzf2mQA:10 a=IkcTkHD0fZMA:10 a=6FF3Zhj9_vgA:10 a=q2GGsy2AAAAA:8 a=u3gE38za3XqOkYTppzIA:9 a=QEXdDO2ut3YA:10 a=z9dJwno5l634igLiVhy-:22 X-Authenticated-Sender: p.w.stephenson@ntlworld.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ntlworld.com; s=meg.feb2017; t=1620922030; bh=94eNkvGValCP3eI3rt2EFGZ+sGnb2glVVxPAwb1xMfo=; h=Date:From:To:Cc:In-Reply-To:References:Subject; b=evlpPmoL3q34IZNvemZJSsjbe37oX70YpfYjOJ33YSJanNIOHYWgwyIfVnEvRKPis P7li95CC/NyeGsM4tIuODQtArj1ZKy59jNvs6HQ593XTBiqJocjeV54Rj9BqRG9L59 p3Mw7JOmPij8mV4fb+hVNixbSQFGFBWm8kpyO2itBTRx3rjp29TtXQBkiLESRFhKI4 0zmKosYqcTm8TCB+AFXUWOmRHi7Tik88FvRA/o0b+GRSl1YoSVesQie8ZplSt0e0gw QgJ+5V5xAs8Tr1U0TTrDjd1NMc5xrZvgZUxKFe6266vBnctX4gcfhGIzeLQV0h1/IH XbNZym+PPrs2w== Date: Thu, 13 May 2021 17:07:10 +0100 (BST) From: Peter Stephenson To: Bart Schaefer , =?UTF-8?Q?J=C3=B6rg_Sommer?= Cc: Zsh Users Message-ID: <119769213.82300.1620922030356@mail2.virginmedia.com> In-Reply-To: References: <20210513101751.j5vo2dbrd5uzwju4@jo-so.de> Subject: Re: Zsh spins in endless loop with SIGHUP + read in zshexit MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Priority: 3 Importance: Medium X-Mailer: Open-Xchange Mailer v7.8.4-Rev72 X-Originating-IP: 147.161.167.79 X-Originating-Client: open-xchange-appsuite X-CMAE-Envelope: MS4xfHSqSB/spxqKnZDq3BY7LVku52ELi/M4YCKAoPzgeVnZWkpjayYFcQiwckY3mqm8x2W4cksj72oelXWZHAFd/xzKGn7Xhb4xBhHDKqrqwJ+X8R/yLIaW gs9qF7oburQ3mW9G9wNOvzTusmO2nD7aQFRp0TuLrDevK7sArQhhGH+ziDvduqlq6En+bNheDEBOSl34ABQDj9fNs6oJg/tyvqMNtxe4amnDCJrvKFa5QD4w 4/e/2OoG8rYq0MGD7Mqh2IsI9lyOXl9I0tgAo08kuwdzNPSbSynHTkwbkryv/NVj X-Seq: 26737 Archived-At: X-Loop: zsh-users@zsh.org Errors-To: zsh-users-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-users-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: > On 13 May 2021 at 16:54 Bart Schaefer wrote: > On Thu, May 13, 2021 at 3:18 AM J=C3=B6rg Sommer wrote: > > > > I'm using `read` in `zshexit` and when my terminal crashes (e.g. XTerm = gets > > killed or ssh connection dies) Zsh spins in an endless loop until I kil= l it > > with SIGKILL (SIGTERM doesn't work). > > [...] > > > > So, if `raw_getbyte` returns `0` `zexit` gets called again. I think thi= s > > causes the loop. >=20 > Yep. zexit() is a no-op there because it doesn't allow itself to > execute recursively. >=20 > There might be other places where similar loops can be triggered. I > see just now PWS has also produced a different patch, which requires > that zexit() return a value; I have no opinion on whether that's > actually preferable. I think the only possible issue with just a break would be if we didn't want to return immediately. But I don't think that's an issue here: zexit() can't do it's "ooh! you've got jobs" because it's way too late, and the repeat over multiple ^D's is handled down here in ZLE anyway, so it's in a position to know that's no-go as well. So don't see why your simple patch shouldn't work. pws