zsh-users
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: Han Pingtian <hanpt@linux.vnet.ibm.com>, zsh-user <zsh-users@zsh.org>
Subject: Re: jobs -Z will destory environ variables
Date: Sat, 17 Nov 2012 09:36:46 -0800	[thread overview]
Message-ID: <121117093646.ZM9645@torch.brasslantern.com> (raw)
In-Reply-To: <20121117085620.GA2500@localhost.localdomain>

On Nov 17,  4:56pm, Han Pingtian wrote:
} 
} Looks like "jobs -Z new_name" will destory the environ of current zsh.

Hmm, this is a new bug.  It works (or at least doesn't destroy the
environment) in 4.2.x even on hosts where it fails in 5.0.

Which means it's not directly related to the hackzero code in bin_fg,
but must instead be related to changes in the handling of the environ
strings themselves -- probably the introduction of setenv / unsetenv
for environment management where previously it was always copied to
new memory space.

So what we need is likely this:

Index: Src/jobs.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/jobs.c,v
retrieving revision 1.92
diff -u -r1.92 jobs.c
--- Src/jobs.c  11 Oct 2012 16:36:14 -0000      1.92
+++ Src/jobs.c  17 Nov 2012 17:35:45 -0000
@@ -1743,12 +1743,14 @@
            goto done;
        p = strchr(q, 0);
     }
+#if !defined(HAVE_PUTENV) && !defined(USE_SET_UNSET_ENV)
     for(; *envp; envp++) {
        q = *envp;
        if(q != p+1)
            goto done;
        p = strchr(q, 0);
     }
+#endif
     done:
     hackspace = p - hackzero;
 #endif


  reply	other threads:[~2012-11-17 17:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-17  8:56 Han Pingtian
2012-11-17 17:36 ` Bart Schaefer [this message]
2012-11-18  2:31   ` Han Pingtian
2012-11-18 18:22     ` Bart Schaefer
2012-12-21 13:35       ` Valodim Skywalker
2012-12-21 15:56         ` Bart Schaefer
2012-12-21 16:36           ` Valodim Skywalker
2012-12-21 16:38           ` Valodim Skywalker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=121117093646.ZM9645@torch.brasslantern.com \
    --to=schaefer@brasslantern.com \
    --cc=hanpt@linux.vnet.ibm.com \
    --cc=zsh-users@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).