zsh-users
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-users@zsh.org
Subject: Re: Local/global history with pattern isearch
Date: Thu, 06 Mar 2014 23:51:24 -0800	[thread overview]
Message-ID: <140306235124.ZM7468@torch.brasslantern.com> (raw)
In-Reply-To: <lfbq4m$duv$1@ger.gmane.org>

On Mar 7,  7:49pm, Jan Larres wrote:
} Subject: Re: Local/global history with pattern isearch
}
} This got me wondering why it wasn't working even though the search
} widget got left alone, and so I went trying to figure out which widget
} *was* the issue. And, possibly to no-one's surprise, that widget turned
} out to be set-local-history.

Aha!  Good catch.

zsh-syntax-highlight is a bit too aggressive about remapping nearly all
the widgets that appear in the output of $(builtin zle -la).  It does
filter out run-help|which-command|beep but there are a number of others
that do not alter the buffer or the cursor position, which also ought
to be excluded:  the suffix widgets (auto-*), the argument widgets
(*-argument|argument-base), reset-prompt, split-undo, and probably
describe-key-briefly and what-cursor-position, plus set-local-history.

If anyone reading this is a zsh-syntax-highlighting developer, you might
consider tweaking the filter at line 137 of zsh-syntax-highlighting.zsh.

I'd also argue that the "hook widgets" (matching the pattern zle-*) need
special treatment.  I'm actually suprised that z-s-h doesn't already use
a zle-line-init widget.


  reply	other threads:[~2014-03-07  7:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-03  4:19 Jan Larres
2014-03-03  5:44 ` Bart Schaefer
2014-03-03 23:44   ` Jan Larres
2014-03-06  4:53     ` Bart Schaefer
2014-03-07  6:49       ` Jan Larres
2014-03-07  7:51         ` Bart Schaefer [this message]
2014-03-11  4:54           ` Jan Larres

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=140306235124.ZM7468@torch.brasslantern.com \
    --to=schaefer@brasslantern.com \
    --cc=zsh-users@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).