From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-users-return-18571-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 17709 invoked by alias); 7 Mar 2014 07:52:07 -0000
Mailing-List: contact zsh-users-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Users List <zsh-users.zsh.org>
List-Post: <mailto:zsh-users@zsh.org>
List-Help: <mailto:zsh-users-help@zsh.org>
X-Seq: 18571
Received: (qmail 7514 invoked from network); 7 Mar 2014 07:51:51 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE
	autolearn=ham version=3.3.2
From: Bart Schaefer <schaefer@brasslantern.com>
Message-id: <140306235124.ZM7468@torch.brasslantern.com>
Date: Thu, 06 Mar 2014 23:51:24 -0800
In-reply-to: <lfbq4m$duv$1@ger.gmane.org>
Comments: In reply to Jan Larres <jan@majutsushi.net>
 "Re: Local/global history with pattern isearch" (Mar  7,  7:49pm)
References: <lf0vss$4ri$1@ger.gmane.org>
	<140302214400.ZM1868@torch.brasslantern.com>	<lf344b$ug1$1@ger.gmane.org>
	<140305205344.ZM5782@torch.brasslantern.com>	<lfbq4m$duv$1@ger.gmane.org>
X-Mailer: OpenZMail Classic (0.9.2 24April2005)
To: zsh-users@zsh.org
Subject: Re: Local/global history with pattern isearch
MIME-version: 1.0
Content-type: text/plain; charset=us-ascii

On Mar 7,  7:49pm, Jan Larres wrote:
} Subject: Re: Local/global history with pattern isearch
}
} This got me wondering why it wasn't working even though the search
} widget got left alone, and so I went trying to figure out which widget
} *was* the issue. And, possibly to no-one's surprise, that widget turned
} out to be set-local-history.

Aha!  Good catch.

zsh-syntax-highlight is a bit too aggressive about remapping nearly all
the widgets that appear in the output of $(builtin zle -la).  It does
filter out run-help|which-command|beep but there are a number of others
that do not alter the buffer or the cursor position, which also ought
to be excluded:  the suffix widgets (auto-*), the argument widgets
(*-argument|argument-base), reset-prompt, split-undo, and probably
describe-key-briefly and what-cursor-position, plus set-local-history.

If anyone reading this is a zsh-syntax-highlighting developer, you might
consider tweaking the filter at line 137 of zsh-syntax-highlighting.zsh.

I'd also argue that the "hook widgets" (matching the pattern zle-*) need
special treatment.  I'm actually suprised that z-s-h doesn't already use
a zle-line-init widget.