zsh-users
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@tiny.zanshin.com>
To: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
Cc: zsh-users@sunsite.auc.dk
Subject: Re: how does setopt -m work?
Date: Thu, 11 Mar 1999 07:49:22 -0800 (PST)	[thread overview]
Message-ID: <14055.58882.513014.144480@awayteam.zanshin.com> (raw)
In-Reply-To: <199903110832.JAA17980@beta.informatik.hu-berlin.de>

Sven Wischnowsky writes:
 > 
 > > It's probably a bug that it doesn't rip out the underscores when
 > > doing its matching.  ``setopt -m "autor*"'' will work.  The other
 > > thing to check would be case sensitivity.
 > 
 > Maybe, yes.
 > 
 > Bye
 >  Sven
 > 
 > --- os/options.c	Mon Mar  8 09:06:26 1999
 > +++ Src/options.c	Thu Mar 11 09:29:20 1999
 > @@ -522,11 +522,20 @@
 >  	/* Globbing option (-m) set. */
 >  	while (*args) {
 >  	    Comp com;
 > +	    char *s, *t;
 > +
 > +	    t = p = dupstring(*args);

Is this really the whole patch?  After applying this, I get

../../zsh-3.1.5/Src/options.c: In function `bin_setopt':
../../zsh-3.1.5/Src/options.c:527: `p' undeclared (first use this function)
../../zsh-3.1.5/Src/options.c:527: (Each undeclared identifier is reported only once
../../zsh-3.1.5/Src/options.c:527: for each function it appears in.)
../../zsh-3.1.5/Src/options.c:525: warning: `s' might be used uninitialized in this function
../../zsh-3.1.5/Src/options.c:525: warning: `t' might be used uninitialized in this function

 > +	    while (*t)
 > +		if (*t == '_')
 > +		    chuck(t);
 > +		else {
 > +		    *t = tulower(*t);
 > +		    t++;
 > +		}
 >  
 >  	    /* Expand the current arg. */
 > -	    tokenize(*args);
 > -	    if (!(com = parsereg(*args))) {
 > -		untokenize(*args);
 > +	    tokenize(s);
 > +	    if (!(com = parsereg(s))) {
 >  		zwarnnam(nam, "bad pattern: %s", *args, 0);
 >  		continue;
 >  	    }


  reply	other threads:[~1999-03-11 15:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1999-03-11  8:32 Sven Wischnowsky
1999-03-11 15:49 ` Bart Schaefer [this message]
  -- strict thread matches above, loose matches on Subject: below --
1999-03-11 15:58 Sven Wischnowsky
1999-03-10 22:23 Sweth Chandramouli
1999-03-11  1:48 ` Geoff Wing

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=14055.58882.513014.144480@awayteam.zanshin.com \
    --to=schaefer@tiny.zanshin.com \
    --cc=schaefer@zanshin.com \
    --cc=wischnow@informatik.hu-berlin.de \
    --cc=zsh-users@sunsite.auc.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).