zsh-users
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-users@zsh.org
Subject: Re: How to (properly) remove the last entry from history with command_not_found_handler
Date: Sun, 20 Jul 2014 11:13:54 -0700	[thread overview]
Message-ID: <140720111354.ZM20358@torch.brasslantern.com> (raw)
In-Reply-To: <53CB860C.8080509@sternenrei.ch>

On Jul 20, 11:04am, Jochen Keil wrote:
}
} function command_not_found_handler()
} {
}     sed -i '$d' $HISTFILE
}     return 127
} }
} 
} However, I'm not sure if it's ok to manipulate the history file directly
} with sed, or if I'm risking corruption.

This is likely to be a problem if the failing command spans more than
one line (e.g., a "for" loop with command-not-found in the middle of
it) or if you are using SHARE_HISTORY where there's a race condition
among shells reading the history and shells (re)writing it.

There really isn't any way to "properly" remove an entry once it has been
written to the history file.  You might try some variation of this:

  zshaddhistory() {  whence ${${(z)1}[1]} >/dev/null || return 2 }

There are still problems with that for multi-line commands but the right
way to achieve your desired behavior is to avoid writing out the commands
you don't want, not to write them and then delete them again.


  parent reply	other threads:[~2014-07-20 18:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-20  9:04 Jochen Keil
2014-07-20 17:45 ` Peter Stephenson
2014-07-20 18:13 ` Bart Schaefer [this message]
2014-07-20 20:48   ` Jochen Keil
2014-07-21 17:46     ` ZyX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=140720111354.ZM20358@torch.brasslantern.com \
    --to=schaefer@brasslantern.com \
    --cc=zsh-users@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).