zsh-users
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-users@zsh.org
Subject: Re: rsync --progress stops completion
Date: Thu, 18 Sep 2014 09:36:02 -0700	[thread overview]
Message-ID: <140918093602.ZM7963@torch.brasslantern.com> (raw)
In-Reply-To: <541AA918.8060503@thregr.org>

On Sep 18, 11:42am, Yuri D'Elia wrote:
} Subject: Re: rsync --progress stops completion
}
} On 09/17/2014 05:51 PM, Bart Schaefer wrote:
} > Sure, just add _files to the end of your completer zstyle, e.g.:
} > 
} > zstyle ':completion:*' completer _oldlist _expand _complete _files 
} 
} That would be the heavy handed approach, however I think it would be a
} better approach (in general) to ignore unknown command-line arguments

Two points:

 - this doesn't help in the example in question because the command-line
   argument isn't unknown; it's both known and specifically excluded.

 - I don't follow how this is "heavy handed"; when the context parse
   goes wrong (or intentionally fails), the completion has to fall back
   on *something*.  What would you like that something to be, and how
   would you like to tell the completion system about it, if not in the
   completer zstyle?

} Some sort of visual clue that the completion stopped because of an error
} could also be helpful maybe?

This might help:

_oopsie() { _message "No completions" }
zstyle ':completion:*:messages' format %S%d%s
zstyle ':completion:*' completer _oldlist _expand _complete _oopsie

We could also consider this (I'm not sure what unexpected side-effects
there might be, particularly for completers that try multiple calls
to _arguments):

diff --git a/Completion/Base/Utility/_arguments b/Completion/Base/Utility/_arguments
index d70c442..e9586e6 100644
--- a/Completion/Base/Utility/_arguments
+++ b/Completion/Base/Utility/_arguments
@@ -570,5 +570,6 @@ if (( $# )) && comparguments -i "$autod" "$singopt[@]" "$@"; then
 
   [[ nm -ne "$compstate[nmatches]" ]]
 else
+  _message "$service cannot parse command line"
   return 1
 fi


  reply	other threads:[~2014-09-18 16:36 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-16 15:00 Yuri D'Elia
2014-09-16 15:09 ` Vadim A. Misbakh-Soloviov
2014-09-16 17:50   ` Yuri D'Elia
2014-09-17  0:51     ` Bart Schaefer
2014-09-17  8:08       ` Yuri D'Elia
2014-09-17 15:51         ` Bart Schaefer
2014-09-18  9:42           ` Yuri D'Elia
2014-09-18 16:36             ` Bart Schaefer [this message]
2014-09-19  2:01               ` Bart Schaefer
2014-09-19  3:22                 ` Mikael Magnusson
2014-09-19 11:40                 ` Oliver Kiddle
2014-09-21  0:48                   ` Bart Schaefer
2014-09-20 13:25                 ` Yuri D'Elia
2014-09-20 18:20                   ` Bart Schaefer
2014-09-21 16:43                     ` Yuri D'Elia
2014-09-21 17:20                       ` Bart Schaefer
2014-09-21 17:33                         ` Yuri D'Elia
2014-09-21 19:38                           ` Bart Schaefer
2014-09-21 20:27                             ` Yuri D'Elia
2014-09-21 20:37                               ` Yuri D'Elia
2014-09-21 22:07                                 ` Bart Schaefer
2014-09-21 22:29                                   ` Yuri D'Elia
2014-09-22  6:58                                     ` Bart Schaefer
2014-09-21 21:08                               ` Bart Schaefer
2014-09-21 21:35                                 ` Yuri D'Elia
2014-09-21 21:54                                   ` typeset -g (was Re: rsync --progress stops completion) Bart Schaefer
2014-09-21 18:52                         ` rsync --progress stops completion Yuri D'Elia
2014-09-21 18:59                         ` Yuri D'Elia
2014-09-20 13:20               ` Yuri D'Elia
2014-09-23 14:23                 ` Oliver Kiddle
2014-09-23 14:43                   ` Peter Stephenson
2014-09-16 15:25 ` Vadim A. Misbakh-Soloviov
2014-09-16 16:28 ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=140918093602.ZM7963@torch.brasslantern.com \
    --to=schaefer@brasslantern.com \
    --cc=zsh-users@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).