From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-users-return-20051-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 1461 invoked by alias); 31 Mar 2015 04:52:29 -0000
Mailing-List: contact zsh-users-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Users List <zsh-users.zsh.org>
List-Post: <mailto:zsh-users@zsh.org>
List-Help: <mailto:zsh-users-help@zsh.org>
X-Seq: 20051
Received: (qmail 13864 invoked from network); 31 Mar 2015 04:52:27 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW
	autolearn=ham version=3.3.2
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:from:message-id:date:in-reply-to:comments
         :references:to:subject:mime-version:content-type;
        bh=T5grFZRor7RWyIEPra2USCWZwbtfaPH21kXOKcuCwXo=;
        b=BUt3wSzYql3qtnfZmU8BvHi0fofe5DkxQlsKuCQTZeFbdK1WkKeWqy0qSh6GqsKomi
         AGIp5D0L7hoa/I3+YkaOeUTDqYc7tJXEMmI5el7I9WHkmBV+1UT89n6Fn+qiUFJ9BtR5
         CZCdqDep6ybBpeaTxzulF1GKuxB8fp4Lqi/fyKbvP0CzFOK+jKP9iIeN06+pihyyD8N3
         C9teGErcnMdUoSZ4+pYzB7pn0pKqBxbURFcOyOXHrDqwMoV7UUFXcnKeZn+KCfPcDMFo
         hSpauWpgVNQiEKtYVy1fKuVFjeu3f02WTpOQmh10+W9lAo202xSQzPRRqGzUJBEPQJou
         RJMw==
X-Gm-Message-State: ALoCoQksroL0a+V8Z7870VJXPXAMt0TSTlL1wkpJokralkvhF7uebIsPLZfOhbq4gQCsT1lyAsAP
X-Received: by 10.60.158.73 with SMTP id ws9mr31050208oeb.24.1427777543538;
        Mon, 30 Mar 2015 21:52:23 -0700 (PDT)
From: Bart Schaefer <schaefer@brasslantern.com>
Message-Id: <150330215220.ZM28507@torch.brasslantern.com>
Date: Mon, 30 Mar 2015 21:52:20 -0700
In-Reply-To: <5519F807.2030006@gmx.com>
Comments: In reply to Eric Cook <llua@gmx.com>
        "Re: device cannot be completed after "ip link show dev"" (Mar 30,  9:27pm)
References: <20150330033930.GB2856@localhost.localdomain> 
	<5519F807.2030006@gmx.com>
X-Mailer: OpenZMail Classic (0.9.2 24April2005)
To: zsh-users@zsh.org
Subject: Re: device cannot be completed after "ip link show dev"
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii

On Mar 30,  9:27pm, Eric Cook wrote:
}
} I can't seem to find a pattern that works in both cases, but adding the
} previous line back allows completing after: `ip link show dev'.
} But after the argument for `dev', the option `up' is no longer show.
} 
} Hopefully someone with better knowledge of the _regex_* functions could
} help.

I don't really know _regex_* "better" -- in fact I've barely looked at it
before -- but based on the "either aaa or bbb" example in the doc, what
about this?


diff --git a/Completion/Unix/Command/_ip b/Completion/Unix/Command/_ip
index 3b68c35..c0a28d3 100644
--- a/Completion/Unix/Command/_ip
+++ b/Completion/Unix/Command/_ip
@@ -9,7 +9,8 @@
 # Values encoding simple types
 #
 local -a subcmd_dev
-subcmd_dev=(/$'[[:alnum:][:punct:][:cntrl:][:digit:]]##\0'/ ':interfaces:network interface:_net_interfaces')
+subcmd_dev=(/$'[[:alnum:][:punct:][:cntrl:][:digit:]]##\0'/ ':interfaces:network interface:_net_interfaces' "|"
+  /$'dev\0'/ ':interfaces:network interface:_net_interfaces')
 
 local -a subcmd_onoff
 subcmd_onoff=(/$'(on|off)\0'/ ':onoff:state (on or off):(on off)')


I suspect there should be some way to use the "-GUARD" syntax to prevent
"dev" from completing again after "dev" ("ip link show dev dev" doesn't
make sense, does it?) but there's no example of using a guard, and as
someone implied, offering too much (as long as it's not *TOO* much) is
better than offering too little.