zsh-users
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: "Zsh Users' List" <zsh-users@zsh.org>
Subject: Re: tag-order with git refs
Date: Wed, 7 Oct 2015 20:50:11 -0700	[thread overview]
Message-ID: <151007205011.ZM3230@torch.brasslantern.com> (raw)
In-Reply-To: <28911.1444256551@thecus.kiddle.eu>

On Oct 8, 12:22am, Oliver Kiddle wrote:
> Subject: Re: tag-order with git refs
>
> It also doesn't help that in a couple of cases functions are called
> sequentially instead of using _alternative. The following patch helps a
> tiny bit with this.
>  
>  (( $+functions[__git_heads] )) ||
>  __git_heads () {
> -  __git_heads_local
> -  __git_heads_remote
> +  _alternative \
> +    'heads-local::__git_heads_local' \
> +    'heads-remote::__git_heads_remote'
>  }

I think this will also end up passing TAG:DESCR:ACT (with empty DESCR)
down to _all_labels, which will take the "if" branch that adds the -J
option to compadd to make the tag a group name.

(time passes)

And indeed the patch does accomplish that, so now there is a group named
heads-local, but the style Peter thinks should work, still does not.

On the other hand, the style Oliver suggested with the list of "all tags
along the path" does exactly what Peter wants.  Oliver, can you explain
why?


  reply	other threads:[~2015-10-08  3:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-07 11:08 Peter Stephenson
2015-10-07 13:01 ` Mikael Magnusson
2015-10-07 13:24   ` Peter Stephenson
2015-10-07 19:06     ` Bart Schaefer
2015-10-07 22:22 ` Oliver Kiddle
2015-10-08  3:50   ` Bart Schaefer [this message]
2015-10-08  9:39   ` Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=151007205011.ZM3230@torch.brasslantern.com \
    --to=schaefer@brasslantern.com \
    --cc=zsh-users@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).