From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24870 invoked by alias); 20 Aug 2018 13:06:26 -0000 Mailing-List: contact zsh-users-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Users List List-Post: List-Help: List-Unsubscribe: X-Seq: 23591 Received: (qmail 25133 invoked by uid 1010); 20 Aug 2018 13:06:25 -0000 X-Qmail-Scanner-Diagnostics: from wout2-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(64.147.123.25):SA:0(-2.6/5.0):. Processed in 2.481708 secs); 20 Aug 2018 13:06:25 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.1 X-Envelope-From: d.s@daniel.shahaf.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=uktvUV EAeTIuZJxQ368Im33APoqyQSK5GdBr5AKyO0M=; b=nx0iy4D5l6AMjmMdBx856l vqxd4H+7SyRZANv26SxrrEjOB4Sb0Ex5/PMLkJsBN63rrY48htl5nOdlCMLFNzIF dQN9evoQQ2EowXLCnlgrOMPldEBWDhfwPAZttifB3eL693Dq65bu2dxejtkEXu9U DQa7jVzLy5hi8SohufsJnYQN0BcJqvfltWcbtThhZSaSbYq6xMN0mW9GbHKv7qI+ dSop7nnrht6kjL2rYXlILWHWoxSxD6/fdOJj67BnhyKF6wnCxy7q9cY9kihRmLyO opxwCTWLqAfjA82kPGV3zZSMhlccqwnwA22eUn3O3MRSzxK22Ix4VCLltSMgtZVg == DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=uktvUV EAeTIuZJxQ368Im33APoqyQSK5GdBr5AKyO0M=; b=fDgumMHAhE1aq1J5AFyRFI UZ+NxRaH/bl1hWo2cKHvf2W0rNguuB4kz4tWSlX/qlo3uyX86uXnX3NiSlYL9nfB +3/rih2f1Gjvt5q2oBhAbWRXq6WO67eX5kJtzk/jZqV8qFIfMl1Q5yNFf+KWREos k9wusXfnBDC3U+yopTplH13qxIsHgKAg1ioM4cXedZDykI+qCzuqY1JXp6/YXkB7 WISGDsDhmDUwjrQF7dwZw8KHGAcB48l8Pt8kZDqmHoQOza8GdmeXkwGQT5HizZ1I v3StG9VdC84Mez4tpPosU0UURp4xidTqA+mKMrB+fmSsn3qYUGiRa06NABXxnITw == X-ME-Proxy: X-ME-Sender: Message-Id: <1534769912.102537.1479915000.00485AFF@webmail.messagingengine.com> From: Daniel Shahaf To: zsh-users@zsh.org MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" X-Mailer: MessagingEngine.com Webmail Interface - ajax-7b72137a Subject: Re: edit-command-line breaks out of vared Date: Mon, 20 Aug 2018 12:58:32 +0000 In-Reply-To: References: <20180819122254.mgx2kfbnbsxxtuqk@tarpaulin.shahaf.local2> Bart Schaefer wrote on Sun, 19 Aug 2018 12:03 -0700: > > On Sun, Aug 19, 2018 at 2:22 PM, Daniel Shahaf wrote: > >> > >> I expected quitting the editor to let me resume the vared session > > My first inclination here is to ask why you expected that ... > > >> instead it left me with the variable's value as a command line. > > ... because the name of the function is edit-command-line, after all. > I assumed edit-command-line would work inside vared, despite the name, and that when $EDITOR finished it would return me to the previous context. > On Sun, Aug 19, 2018 at 6:18 AM, Mikael Magnusson wrote: > > This works in my version of edit-command-line, > > > > + [[ -z $PREBUFFER ]] && { > > Hrm, is PREBUFFER really guaranteed to be empty whenever vared is > running? I suppose so. Is there a reason not to commit that? Before we might've thought it was only an optimisation but now it seems to enable behaviour that isn't possible with the code in HEAD. I don't see anything in my archives about reasons not to commit that. Cheers, Daniel