From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: zsh-users-return-23645-ml=inbox.vuxu.org@zsh.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 3b33794e for ; Mon, 17 Sep 2018 13:01:38 +0000 (UTC) Received: (qmail 25381 invoked by alias); 17 Sep 2018 13:01:19 -0000 Mailing-List: contact zsh-users-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Users List List-Post: List-Help: List-Unsubscribe: X-Seq: 23645 Received: (qmail 14924 invoked by uid 1010); 17 Sep 2018 13:01:18 -0000 X-Qmail-Scanner-Diagnostics: from out1-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(66.111.4.25):SA:0(-2.6/5.0):. Processed in 7.034089 secs); 17 Sep 2018 13:01:18 -0000 X-Envelope-From: d.s@daniel.shahaf.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=DAd37E l1Lu/DxUK/h+0k7SgLuVbdp/WXDAPvZ0BX2/U=; b=i7h2v4+3nL2zCNLjjj8wsN W+m1Hdp7qR+69xq1p8nO1DJ5OXg55bRVmS66kUNFn9iPmCvjwUyAZ779IuEiQxyY xO5O/DzkEYEdSrtkM29Tp3os4ZzamlnmRTB03AWqeIUHvgxTmq4pWKT6PU0+n+Nd vbO9OSziksbn6y3pRaorYEs7fix9K0TJ7ROtkR4IzBH4M8oPXy2xVewGpzcDie9d Ko0Y3vcyqDL9qzpxPMz3fUk0ojVGS1ACIjv0F11Fwl8QSlczHuzBZtx/PUBTbtj7 P3xlED4kx3qgOT77eobul4QnZ9v87/Ko36fxwVAn58nNWKq+CEvntAjNjEEKYtwQ == DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=DAd37E l1Lu/DxUK/h+0k7SgLuVbdp/WXDAPvZ0BX2/U=; b=k+NGHjuppethm87d2d3cmx Exl45TDF6YTKcFHANXOt+VBR1ArGkzBbIU5l9IBwGw5s6z3eZYL+kO7uhMqndO/6 29HSC69AwuiSp2YuJsJuWlpWLzGU8JyGn2cFig95B2G3qcfnJO1vjNKRnVRoZXph dNxzQoQBMs3Bd0sd1azRU/o/K+8CftokrkbDZ4ZC2P+gidfZoq+5sl+oEeLvczNB 0Ul+uMVNRKUqunEP42Ct/X2+RCVkibMrFXmUV4gfp1NtzTX8xhwzANgCMhsUizyX TPiJp6ug4z15zuZyDwS019vZTTtSO5DmMIhDghzVRnju0Lep9kByD1FLnOqRO5fA == X-ME-Proxy: X-ME-Sender: Message-Id: <1537189264.3230152.1510729240.5AE4F7C2@webmail.messagingengine.com> From: Daniel Shahaf To: dana , Takeshi Banse Cc: zsh-users@zsh.org MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" X-Mailer: MessagingEngine.com Webmail Interface - ajax-e556cd15 Subject: Re: change in zstyle file-patterns handling between 5.5.1 & 5.6(.2)? References: <25E31A55-5918-42B8-83B4-DDC58A2D52EA@bitraven.io> <20180917022715.GA17398@laafc.net> In-Reply-To: Date: Mon, 17 Sep 2018 13:01:04 +0000 dana wrote on Mon, 17 Sep 2018 00:58 -0500: > On 16 Sep 2018, at 21:27, Takeshi Banse wrote: > >If I revert the commit 6b4e78dce6a505d8dab5554d9925e38e13bb40ea like > >a workaround diff hunk at the end of this mail, it works here for these > >2 particular issues. > > I guess this one is mine, sorry. :/ > > Going back over it, i'm having trouble remembering exactly why i changed _files; > as far as i know, it's not necessary to fix the _object_files problem i found. > Maybe during troubleshooting i noticed that the one _path_files call was > different from the other two in that function, and i decided it was a mistake? > Sounds like the kind of dumb thing i'd do. > > Unless someone else can figure out what past-me was going for, i'm in favour of > reverting that half of the change per your patch. Should the order of "$@" and "${(@)expl}" in the _object_files part of that patch be reversed? In general, the parameters should be ordered so a function's caller has an opportunity to override defaults set by the function; so options in "$@" should be placed so as to override those in "$expl[@]". I'm not sure, however, what that means in practice. I *thought* that in compadd, when an option flag is repeated its last occurrence wins, but 'compadd -ld foo -d bar' uses $foo, not $bar... Cheers, Daniel