From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-users-return-21244-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 2234 invoked by alias); 5 Feb 2016 17:20:40 -0000
Mailing-List: contact zsh-users-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Users List <zsh-users.zsh.org>
List-Post: <mailto:zsh-users@zsh.org>
List-Help: <mailto:zsh-users-help@zsh.org>
X-Seq: 21244
Received: (qmail 7102 invoked from network); 5 Feb 2016 17:20:40 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID
	autolearn=ham autolearn_force=no version=3.4.1
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=brasslantern-com.20150623.gappssmtp.com; s=20150623;
        h=from:message-id:date:in-reply-to:comments:references:to:subject
         :mime-version:content-type;
        bh=yuGgr88yCJvD8MMRhd3VBUD7cNKpgZSCR3jfQNZwe80=;
        b=NgvPcSKax17XrKLMBK8HrRB9gsAO5dsjzaHkgg9ZAtpRiUIzyOl7Q84dfk/XL6mx5c
         hI+gnJcbofIhdSB8ehSWbvE2ZbkGagGG/rQ+PWKwm25eYjF6HCk6RHHeAO7W6QzT30e7
         PKuakUySAsPqaKXTsZ3/EqhS30L6p4rIpX7Zbzw2kF80zl2sxqQrukDF4CSvAWf7jgUS
         4x84OwBaSISaPnt3LD/bgszsT5sCT1tlOQY9uV9rngfL8i6FU2zLPYMYVlwr7U/Iowz2
         xT7Oo6xKaVY15YqMl+zo38eh73MtMgdFbc6THsRtifVbRUuBZVnM7hzVZcNiqncURMPN
         sKPA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:from:message-id:date:in-reply-to:comments
         :references:to:subject:mime-version:content-type;
        bh=yuGgr88yCJvD8MMRhd3VBUD7cNKpgZSCR3jfQNZwe80=;
        b=BTqyuy3YqmKsUqOhAPapKH4/GAO46PaF7xQobCXe7j26SisjUp7J9YXKdl6hWLd+z1
         VtF9NZQs7oXsUSWCOBvbCPuI3cqACFo8wvOY1lsBQh8pPE7K+ZijZeG5VAPWzm8Oygqf
         IE37hKzKfBcQoHFm04x0aAPL8RnOkzCy2nICnki8EDNv7DJRvVhOo/dEu48i8NBZyi75
         lpXfCRawwFmLYoogWa5g4vAigVooTPPd4QfXHbk5MYflGY5NJXideRsXkKDOdsCQ9E47
         nm043d76JGWZjCYcfAnnpzR0SSG8GkYJEbcnM9XVIsAeGfFA5l5++/sZGQz6riXwsLUh
         Xu9A==
X-Gm-Message-State: AG10YOQ1Pu29FW0coO3UTCG9ai3fmtmd9HpPhVZ+yNZQOs5JQiRRwNzRTtxeoIPd5XBjnw==
X-Received: by 10.66.255.6 with SMTP id am6mr5616408pad.106.1454692837865;
        Fri, 05 Feb 2016 09:20:37 -0800 (PST)
From: Bart Schaefer <schaefer@brasslantern.com>
Message-Id: <160205092038.ZM29758@torch.brasslantern.com>
Date: Fri, 5 Feb 2016 09:20:38 -0800
In-Reply-To: <20160205164606.7ff9d27d@pwslap01u.europe.root.pri>
Comments: In reply to Peter Stephenson <p.stephenson@samsung.com>
        "Re: PATCH: funcstack[-1]  (formerly Suppress tracing of "set +x")" (Feb  5,  4:46pm)
References: <20151230104531.GA20496@linux.vnet.ibm.com> 
	<5683F898.7010907@inlv.org> 
	<20160205100902.GA14979@linux.vnet.ibm.com> 
	<20160205102735.1f09973a@pwslap01u.europe.root.pri> 
	<20160205104444.2437ad33@pwslap01u.europe.root.pri> 
	<20160205160236.1274aa5b@pwslap01u.europe.root.pri> 
	<160205081428.ZM29587@torch.brasslantern.com> 
	<20160205164606.7ff9d27d@pwslap01u.europe.root.pri>
X-Mailer: OpenZMail Classic (0.9.2 24April2005)
To: zsh-users@zsh.org
Subject: Re: PATCH: funcstack[-1]  (formerly Suppress tracing of "set +x")
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii

On Feb 5,  4:46pm, Peter Stephenson wrote:
} Subject: Re: PATCH: funcstack[-1]  (formerly Suppress tracing of "set +x")
}
} On Fri, 05 Feb 2016 08:14:28 -0800
} Bart Schaefer <schaefer@brasslantern.com> wrote:
} > On Feb 5,  4:02pm, Peter Stephenson wrote:
} > }
} > } My main worry is someone is using ${#funcstack} to decide if they're at
} > } top-level, rather than zsh_eval_context, which would now fail.
} > 
} > There are several uses of $#funcstack in the Completion/ function suite.
} 
} None of them are sensitive to (permanently) adding an extra level at the
} end of the array, as far as I can see.

My concern is that $_tags_level is initialized to 0 in _main_complete
and then compared to $#funcstack later.  If $#funcstack is now always no
less than 1, that will be wrong.

Of course we can fix _main_complete to initialize to 1, but this does
imply that comparisons to $#funcstack are not an unknown programming
technique.