zsh-users
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: ZSH Mail List <zsh-users@zsh.org>, ZSH Mail List <zsh-users@zsh.org>
Cc: "Vadim A. Misbakh-Soloviov" <mva@mva.name>
Subject: Re: menu-completion bug
Date: Sun, 19 Mar 2017 18:54:22 -0700	[thread overview]
Message-ID: <170319185422.ZM26428@torch.brasslantern.com> (raw)
In-Reply-To: <1721226.EHNCKcHUvk@note>

On Mar 16,  1:42am, Vadim A. Misbakh-Soloviov wrote:
}
} If you see that pre-last column items getting "reversed" green colour
} (i.e. foreground=terminal-default-fg-color,background=green), then you
} just confirmed bug.

This isn't strictly a completion bug, rather it's a problem with the
coloring support in the complist module.

There are several things going on at once here -- the matches are being
color-coded, the menu navigation is maintaining the reverse-video for
the current selection position, and various things like the "@" between
username and hostname are being highlighted on the command line.  For
some of these there is no explicit ANSI sequence to turn exactly one
attribute off, instead everything has to be reset.  So on some of the
repaint positions, the sequences to turn a new effect on are issued,
and an artifact of the old sequences is left.

This seems to come down to whether clprintm(), called from singledraw()
at line 1947, returns early without outputting anything.  That works if
only the default colors are being used, but not when the "normal text"
color has been changed.  So I suspect it's an optimization gone wrong.

That's as far as I've gotten.  Further discussion should probably be on
the zsh-workers list.


      reply	other threads:[~2017-03-20  1:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-15 18:42 Vadim A. Misbakh-Soloviov
2017-03-20  1:54 ` Bart Schaefer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=170319185422.ZM26428@torch.brasslantern.com \
    --to=schaefer@brasslantern.com \
    --cc=mva@mva.name \
    --cc=zsh-users@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).