From: Danek Duvall <duvall@dhduvall.student.Princeton.EDU>
To: Zsh users list <zsh-users@math.gatech.edu>
Subject: appendhistory and history file truncation
Date: Sat, 21 Oct 1995 03:58:32 -0400 [thread overview]
Message-ID: <199510210758.DAA01183@dhduvall.student.Princeton.EDU> (raw)
I haven't seen this show up on the list, so I thought I'd chime in.
I'm having a problem wherein whenever I start up an invocation of zsh
(2.6 beta10), my history file gets wiped. It doesn't happen when
NO_RCS is set (if I do zsh -f). It seems that even though
APPENDHISTORY is set, savehistfile() ends up opening the file mode
O_TRUNC on line 1471 of hist.c (at least, I think this is the
culprit). Perhaps this line should be rewritten as the block in lines
1420-1423.
I checked beta11-test10, and it hasn't been fixed.
Here's a really straightforward patch to beta10, which *should* fix
the problem, though I haven't tested it. Rewrite as you wish, but I
think this is the right thing to do.
Thanks,
Danek
--- hist.c.orig Sat Oct 21 03:54:08 1995
+++ hist.c Sat Oct 21 03:56:30 1995
@@ -1468,7 +1468,11 @@
histnum++;
}
fclose(out);
- if ((out = fdopen(open(s, O_WRONLY | O_TRUNC, 0600), "w"))) {
+ if (app & 1)
+ out = fdopen(open(s, O_CREAT | O_WRONLY | O_APPEND, 0600), "a");
+ else
+ out = fdopen(open(s, O_CREAT | O_WRONLY | O_TRUNC, 0600), "w");
+ if (out) {
if (histnum < savehist)
for (i = 0; i < histnum; i++)
fprintf(out, "%s", store[i]);
--
Danek Duvall <duvall@lorien.princeton.edu> For my PGP key, send mail with
Computer Science, Princeton University subject "get pgp key" or look
http://lorien.princeton.edu/~duvall/ it up on the keyservers.
next reply other threads:[~1995-10-21 8:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
1995-10-21 7:58 Danek Duvall [this message]
1995-10-21 15:27 ` Mark Borges
1995-10-22 6:14 ` Zvi Har'El
1995-10-22 23:45 ` Zoltan Hidvegi
1995-10-22 10:31 ` Zvi Har'El
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=199510210758.DAA01183@dhduvall.student.Princeton.EDU \
--to=duvall@dhduvall.student.princeton.edu \
--cc=zsh-users@math.gatech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).