From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from gatech.edu (gatech.edu [130.207.244.244]) by werple.net.au (8.7/8.7.1) with SMTP id SAA15888 for <mason@werple.mira.net.au>; Sat, 21 Oct 1995 18:05:44 +1000 (EST)
Received: from euclid (euclid.skiles.gatech.edu) by gatech.edu with SMTP id AA01733
  (5.65c/Gatech-10.0-IDA for <mason@werple.mira.net.au>); Sat, 21 Oct 1995 03:59:22 -0400
Received: by euclid (5.x/SMI-SVR4)
	id AA05457; Sat, 21 Oct 1995 03:57:49 -0400
Old-Return-Path: <zsh-users-request@math.gatech.edu>
Resent-Date: Sat, 21 Oct 1995 03:58:32 -0400
Old-Return-Path: <duvall@lorien.princeton.edu>
Date: Sat, 21 Oct 1995 03:58:32 -0400
Message-Id: <199510210758.DAA01183@dhduvall.student.Princeton.EDU>
From: Danek Duvall <duvall@dhduvall.student.Princeton.EDU>
To: Zsh users list <zsh-users@math.gatech.edu>
Subject: appendhistory and history file truncation
Resent-Message-Id: <"8Tof51.0.0L1.mVAYm"@euclid>
Resent-From: zsh-users@math.gatech.edu
X-Mailing-List: <zsh-users@math.gatech.edu> archive/latest/107
X-Loop: zsh-users@math.gatech.edu
X-Loop: zsh-workers@math.gatech.edu
Precedence: list
Resent-Sender: zsh-workers-request@math.gatech.edu

I haven't seen this show up on the list, so I thought I'd chime in.

I'm having a problem wherein whenever I start up an invocation of zsh
(2.6 beta10), my history file gets wiped.  It doesn't happen when
NO_RCS is set (if I do zsh -f).  It seems that even though
APPENDHISTORY is set, savehistfile() ends up opening the file mode
O_TRUNC on line 1471 of hist.c (at least, I think this is the
culprit).  Perhaps this line should be rewritten as the block in lines
1420-1423.

I checked beta11-test10, and it hasn't been fixed.

Here's a really straightforward patch to beta10, which *should* fix
the problem, though I haven't tested it.  Rewrite as you wish, but I
think this is the right thing to do.

Thanks,
Danek

--- hist.c.orig	Sat Oct 21 03:54:08 1995
+++ hist.c	Sat Oct 21 03:56:30 1995
@@ -1468,7 +1468,11 @@
 		histnum++;
 	    }
 	    fclose(out);
-	    if ((out = fdopen(open(s, O_WRONLY | O_TRUNC, 0600), "w"))) {
+	    if (app & 1)
+		out = fdopen(open(s, O_CREAT | O_WRONLY | O_APPEND, 0600), "a");
+	    else
+		out = fdopen(open(s, O_CREAT | O_WRONLY | O_TRUNC, 0600), "w");
+	    if (out) {
 		if (histnum < savehist)
 		    for (i = 0; i < histnum; i++)
 			fprintf(out, "%s", store[i]);

-- 
Danek Duvall <duvall@lorien.princeton.edu>    For my PGP key, send mail with
Computer Science, Princeton University        subject "get pgp key" or look
http://lorien.princeton.edu/~duvall/          it up on the keyservers.