From: John S Cooper <john.cooper@Eng.Sun.COM>
To: schaefer@nbn.com
Cc: John S Cooper <jsc@Eng.Sun.COM>, zsh-users@math.gatech.edu
Subject: Re: `popd' is blocked on non-existent directory
Date: Wed, 16 Oct 1996 17:56:33 -0700 [thread overview]
Message-ID: <199610170056.RAA09115@kontiki.Eng.Sun.COM> (raw)
In-Reply-To: <961015222654.ZM27814@candle.brasslantern.com>
[-- Attachment #1: Type: text/plain, Size: 939 bytes --]
Bart Schaefer writes:
> The compatible-with-other-shells behavior in this case would be to issue a
> `directory stack empty' error message. (However, I could see an argument
> that PUSHD_TO_HOME ought to apply to popd as well.)
Thanks. I've added a little code to do what you suggest and have popd also
honor the PUSHD_TO_HOME option. Now, if you popd when there's a single
dirstack entry and PUSHD_TO_HOME is set, it'll pop you to your home
directory:
160 kontiki%> setopt pushdtohome
162 kontiki%> dirs /usr/bin /tmp
163 kontiki%> dirs
~ /usr/bin /tmp
164 kontiki%> popd
/usr/bin /tmp
165 kontiki%> popd
/tmp
165 kontiki%> popd
~
.. and with pushdtohome unset:
156 kontiki%> unsetopt pushdtohome
157 kontiki%> dirs /usr/bin /tmp
158 kontiki%> dirs
~ /usr/bin /tmp
159 kontiki%> popd
/usr/bin /tmp
160 kontiki%> popd
/tmp
160 kontiki%> popd
popd: directory stack empty
I've attached the diffs (which include your changes):
[-- Attachment #2: Type: text/plain, Size: 1661 bytes --]
*** builtin.c Wed Oct 16 17:31:48 1996
--- builtin.c.orig Wed Oct 16 16:11:23 1996
***************
*** 998,1018 ****
char *dest;
if (!argv[0]) {
- if (func == BIN_POPD && !nextnode(firstnode(dirstack))) {
- if (unset(PUSHDTOHOME)) {
- zwarnnam(nam, "directory stack empty", NULL, 0);
- return NULL;
- }
- else {
- pushnode(dirstack, ztrdup(home));
- dir = nextnode(firstnode(dirstack));
- }
- }
if (func == BIN_PUSHD && unset(PUSHDTOHOME))
dir = nextnode(firstnode(dirstack));
if (dir)
insertlinknode(dirstack, dir, getlinknode(dirstack));
! else if (func != BIN_POPD)
pushnode(dirstack, ztrdup(home));
} else if (!argv[1]) {
int dd;
--- 998,1008 ----
char *dest;
if (!argv[0]) {
if (func == BIN_PUSHD && unset(PUSHDTOHOME))
dir = nextnode(firstnode(dirstack));
if (dir)
insertlinknode(dirstack, dir, getlinknode(dirstack));
! else
pushnode(dirstack, ztrdup(home));
} else if (!argv[1]) {
int dd;
***************
*** 1058,1063 ****
--- 1048,1054 ----
target = dir;
if (func == BIN_POPD) {
if (!dir) {
+ zsfree(getlinknode(dirstack));
target = dir = firstnode(dirstack);
} else if (dir != firstnode(dirstack)) {
return dir;
***************
*** 1070,1077 ****
if (!(dest = cd_do_chdir(nam, getdata(dir)))) {
if (!target)
zsfree(getlinknode(dirstack));
- if (func == BIN_POPD)
- zsfree(remnode(dirstack, dir));
return NULL;
}
if (dest != getdata(dir)) {
--- 1061,1066 ----
prev parent reply other threads:[~1996-10-17 1:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
1996-10-16 2:02 John S Cooper
1996-10-16 5:26 ` Bart Schaefer
1996-10-17 0:56 ` John S Cooper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=199610170056.RAA09115@kontiki.Eng.Sun.COM \
--to=john.cooper@eng.sun.com \
--cc=jsc@Eng.Sun.COM \
--cc=schaefer@nbn.com \
--cc=zsh-users@math.gatech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).