Re: menu-select in 3.1.9

Re: menu-select in 3.1.9

[Sven Wischnowsky]

Andy Spiegl wrote:

> > } I just upgraded from 3.1.7-pre4 to 3.1.9 and menu-selection isn't working
> > } anymore. :-(
> > 
> > I think it's working in the release version of 3.1.9, but not in the most
> > recent CVS snapshot.
> Actually I thought I installed the release version.  Hm...
> So, it's bug, not my problem?

Yes, fixed by the patch below (workers/11890).

Bye
 Sven

Index: Src/Zle/complist.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Zle/complist.c,v
retrieving revision 1.26
diff -u -r1.26 complist.c
--- Src/Zle/complist.c	2000/06/13 10:49:19	1.26
+++ Src/Zle/complist.c	2000/06/14 06:37:56
@@ -1493,6 +1493,8 @@
 
     amatches = dat->matches;
 
+    noselect = 0;
+
     if ((minfo.asked == 2 && mselect < 0) || nlnct >= lines) {
 	showinglist = 0;
 	amatches = oamatches;
@@ -1629,8 +1631,6 @@
     int space, lbeg = 0, step = 1, wrap, pl = nlnct, broken = 0, first = 1;
     char *s;
 
-    if (!mtab)
-	return 0;
     if (fdat || (dummy && (!(s = getsparam("MENUSELECT")) ||
 			   (dat && dat->num < atoi(s))))) {
 	if (fdat) {
@@ -1651,7 +1651,7 @@
     mhasstat = (mstatus && *mstatus);
     fdat = dat;
     selectlocalmap(mskeymap);
-    noselect = 0;
+    noselect = 1;
     while ((menuacc &&
 	    !hasbrpsfx(*(minfo.cur), minfo.prebr, minfo.postbr)) ||
 	   (((*minfo.cur)->flags & (CMF_NOLIST | CMF_MULT)) &&

--
Sven Wischnowsky                         wischnow@informatik.hu-berlin.de

Re: menu-select in 3.1.9

[Andy Spiegl]

> } I just upgraded from 3.1.7-pre4 to 3.1.9 and menu-selection isn't working
> } anymore. :-(
> 
> I think it's working in the release version of 3.1.9, but not in the most
> recent CVS snapshot.
Actually I thought I installed the release version.  Hm...
So, it's bug, not my problem?

Thanks!
 Andy.

-- 
 E-Mail: Andy@spiegl.de     URL: http://andy.spiegl.de
 PGP/GPG: see headers
                                o      _     _         _
  --------- __o       __o      /\_   _ \\o  (_)\__/o  (_)
  ------- _`\<,_    _`\<,_    _>(_) (_)/<_    \_| \   _|/' \/
  ------ (_)/ (_)  (_)/ (_)  (_)        (_)   (_)    (_)'  _\o_
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 VENI, VEDI, VISA: I came, I saw, I did a little shopping.

Re: menu-select in 3.1.9

[Bart Schaefer]

On Jun 13,  8:37pm, Andy Spiegl wrote:
} Subject: menu-select in 3.1.9
}
} Hi!
} I just upgraded from 3.1.7-pre4 to 3.1.9 and menu-selection isn't working
} anymore. :-(

I think it's working in the release version of 3.1.9, but not in the most
recent CVS snapshot.

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com

Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net   

menu-select in 3.1.9

[Andy Spiegl]

Hi!
I just upgraded from 3.1.7-pre4 to 3.1.9 and menu-selection isn't working
anymore. :-(

In my dot-files I've got: (among other lines of course)
 setopt always_last_prompt
 zmodload -i zsh/complist
 zstyle ':completion:*' menu select=5

That's what the zsh-guide says, too.
Can some kind soul please clarify what I have to change?

Thanks a lot!
 Andy.

-- 
 E-Mail: Andy@spiegl.de     URL: http://andy.spiegl.de
 PGP/GPG: see headers
                                o      _     _         _
  --------- __o       __o      /\_   _ \\o  (_)\__/o  (_)
  ------- _`\<,_    _`\<,_    _>(_) (_)/<_    \_| \   _|/' \/
  ------ (_)/ (_)  (_)/ (_)  (_)        (_)   (_)    (_)'  _\o_
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 cat /dev/boiler/water | tea | sieve > /cup
 mount -t hdev /dev/human/mouth01 /mouth ; cat /cup >/mouth/gulp