zsh-users
 help / color / mirror / code / Atom feed
From: Wayne Davison <wayned@users.sourceforge.net>
To: Zsh users list <zsh-users@sunsite.dk>
Subject: Re: 4.2.0-pre-2
Date: Wed, 3 Mar 2004 11:39:02 -0800	[thread overview]
Message-ID: <20040303193902.GF9561@blorf.net> (raw)
In-Reply-To: <20040303185321.GE9561@blorf.net>

[-- Attachment #1: Type: text/plain, Size: 415 bytes --]

On Wed, Mar 03, 2004 at 10:53:21AM -0800, Wayne Davison wrote:
> I noticed that someone removed the stamp-h idiom from the Makefile
> recently.

I'm attaching a better patch for Makefile.in.  The old rules had
config.h and config.modules intertwined, and this one breaks them
apart so that config.h doesn't get rebuilt when it doesn't need
to be.

Q: Does "config.modules" need to depend on config.h.in?

..wayne..

[-- Attachment #2: stamp.patch --]
[-- Type: text/plain, Size: 936 bytes --]

--- Makefile.in	14 Feb 2004 18:50:16 -0000	1.12
+++ Makefile.in	3 Mar 2004 19:28:47 -0000
@@ -134,7 +134,11 @@ config.status: $(sdir)/configure
 $(sdir)/configure: $(sdir)/aclocal.m4 $(sdir)/aczsh.m4 $(sdir)/configure.ac
 	cd $(sdir) && autoconf
 
-config.h config.modules: $(sdir)/config.h.in config.status
+config.h: stamp-h
+stamp-h: $(sdir)/config.h.in config.status
+	cd $(dir_top) && $(SHELL) ./config.status config.h $@
+
+config.modules: $(sdir)/config.h.in config.status
 	cd $(dir_top) && $(SHELL) ./config.status $@
 
 $(sdir)/config.h.in: $(sdir)/stamp-h.in
--- configure.ac	1 Mar 2004 17:58:55 -0000	1.11
+++ configure.ac	3 Mar 2004 19:28:48 -0000
@@ -2379,6 +2379,7 @@ AC_SUBST_FILE(VERSION_MK)dnl
 AC_CONFIG_FILES(Config/defs.mk Makefile Doc/Makefile Etc/Makefile \
 Src/Makefile Test/Makefile)
 AC_CONFIG_COMMANDS([config.modules], [. ./config.modules.sh])
+AC_CONFIG_COMMANDS([stamp-h], [echo >stamp-h])
 
 AC_OUTPUT
 

  reply	other threads:[~2004-03-03 19:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-03 14:00 4.2.0-pre-2 Peter Stephenson
2004-03-03 18:53 ` 4.2.0-pre-2 Wayne Davison
2004-03-03 19:39   ` Wayne Davison [this message]
2004-03-03 19:15 ` 4.2.0-pre-2 Ibraheem Umaru-Mohammed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040303193902.GF9561@blorf.net \
    --to=wayned@users.sourceforge.net \
    --cc=zsh-users@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).