Re: zle_thingy.c: variable "modsave" used before its value set

[Wayne Davison <wayned@users.sourceforge.net>]

[-- Attachment #1: Type: text/plain, Size: 525 bytes --]

On Mon, Apr 12, 2004 at 10:38:00AM +0900, Jens Petersen wrote:
> I received a bug report that the local variable `modsave' is
> used uninitialised in bin_zle_call() (zle_thingy.c).

The variable can't actually be used uninitialized -- the compiler just
thinks it can.

If we want to get rid of the warning, I'd recommend making the struct
static rather than initializing it to an unneeded value on every call.
Here's a patch that does this, plus it gets rid of some unneeded cleanup
code that can't get triggered.

..wayne..

[-- Attachment #2: modsave.patch --]
[-- Type: text/plain, Size: 496 bytes --]

--- Src/Zle/zle_thingy.c	12 Dec 2003 22:53:28 -0000	1.12
+++ Src/Zle/zle_thingy.c	12 Apr 2004 08:40:04 -0000
@@ -622,13 +622,11 @@ static int
 bin_zle_call(char *name, char **args, Options ops, char func)
 {
     Thingy t;
-    struct modifier modsave;
+    static struct modifier modsave;
     int ret, saveflag = 0;
     char *wname = *args++;
 
     if (!wname) {
-	if (saveflag)
-	    zmod = modsave;
 	return (!zleactive || incompctlfunc || incompfunc ||
 		sfcontext != SFC_WIDGET);
     }