[patch] _aptitude

[patch] _aptitude

[Francisco Borges]

[-- Attachment #1: Type: text/plain, Size: 855 bytes --]

Hello,

I started using aptitude recently and noticed that the completion for
some commands were not behaving as expected, so I made some trivial
changes to the _aptitude file.

Note that (un)markauto are meant to be used on *installed* packages,
and so I moved them into the appropriated group. Ideally they should
complete on "unmarked/marked" packages, the list of marked packages is
available through

aptitude -F"%p"  search \~M

but (i) that's a bit slow and (ii) I couldn't figure a way to include
this in the completion function (in the 5min I spent trying that is...)

I reckon that some options I just turned ON allow things like
packagename=version and that is not being done, yet "aptitude install"
also allows for things like "~nzsh" and that's not implemented either;
so I concluded that it was OK to do it so.

Cheers,
-- 
Francisco Borges

[-- Attachment #2: _aptitude.diff --]
[-- Type: text/plain, Size: 602 bytes --]

--- /home/borges/sys/zsh/zsh-4.3.2/Completion/Debian/Command/_aptitude	2005-08-10 15:00:41.000000000 +0200
+++ _aptitude	2006-04-20 12:06:55.000000000 +0200
@@ -35,13 +35,13 @@
       search)
         _message -e patterns pattern
       ;;
-      download)
+      download|show|changelog)
         _deb_packages avail && ret=0
       ;;
-      remove|purge|hold)
+      remove|purge|hold|reinstall|forbid-version|markauto|unmarkauto)
         _deb_packages installed && ret=0
       ;;
-      install|markauto|unmarkauto)
+      install)
         _deb_packages uninstalled && ret=0
       ;;
       *)

Re: [patch] _aptitude

[Clint Adams]

> I started using aptitude recently and noticed that the completion for
> some commands were not behaving as expected, so I made some trivial
> changes to the _aptitude file.

Thanks.  Your changes have been incorporated for the next release.

> Note that (un)markauto are meant to be used on *installed* packages,
> and so I moved them into the appropriated group. Ideally they should
> complete on "unmarked/marked" packages, the list of marked packages is
> available through
> 
> aptitude -F"%p"  search \~M

> but (i) that's a bit slow and (ii) I couldn't figure a way to include
> this in the completion function (in the 5min I spent trying that is...)

Since that takes so long, you should probably make use of the caching
layer; search for _cache in the zshcompsys man page or look at
_deb_packages.

To include it without any caching, you can replace your invocation of
_deb_packages with something like this:

   _wanted package expl 'package' compadd $(aptitude -F"%p" search \~M)

> I reckon that some options I just turned ON allow things like
> packagename=version and that is not being done, yet "aptitude install"
> also allows for things like "~nzsh" and that's not implemented either;
> so I concluded that it was OK to do it so.

packagename=version and packagename/suite would be nice additions as
well.