From: Peter Stephenson <pws@csr.com>
To: Zsh users list <zsh-users@sunsite.dk>
Subject: Re: functions/Misc/checkmail doesn't work when MAILPATH is a directory
Date: Fri, 15 Sep 2006 19:07:56 +0100 [thread overview]
Message-ID: <20060915190756.832515e8.pws@csr.com> (raw)
In-Reply-To: <20060915174626.GA9429@localhost.localdomain>
"arno." <arno.@no-log.org> wrote:
> Hi,
> functions/Misc/checkmail is a function that is supposed to output a
> message when new mail is detected (either with function arguments, or
> else $MAILPATH, or else $MAIL, or else /var/spool/mail/$LOGNAME
>
> I use MAILPATH=~/Mail and have many files (mbox) in that directory.
>
> That function doesn't work. That is because
>
> if [[ -d "$file" ]] then
> file=( "$file"/**/*(.ND) )
> if (($#file)) then
> checkmail "${^file}\?$message"
> fi
> fi
>
> checkmail will be called with an array that contains all the files in
> MAILPATH
> but
>
> for file in "${@:-${mailpath[@]:-${MAIL:-/var/spool/mail/$LOGNAME}}}"
>
> will give a scalar.
Not if $@ or $mailpath is an array to begin with. I think the problem is
that in your case $@ wasn't, because of the other bug:
> checkmail "${^file}\?$message"
>
> if message is "Hello", this gives
>
> checkmail file1 file2 file3?Hello
This was passing a single argument because of the double quotes. So I
think fixing this should be enough.
> +setopt noshwordsplit
That's a good thing to do, but probably it's safer to sanitize all the
options... does the following patch work?
Index: Functions/Misc/checkmail
===================================================================
RCS file: /cvsroot/zsh/zsh/Functions/Misc/checkmail,v
retrieving revision 1.4
diff -u -r1.4 checkmail
--- Functions/Misc/checkmail 29 May 2001 17:54:39 -0000 1.4
+++ Functions/Misc/checkmail 15 Sep 2006 18:06:18 -0000
@@ -9,6 +9,7 @@
# This function requires zsh-3.0.1 or newer.
#
+emulate -L zsh
local file message
for file in "${@:-${mailpath[@]:-${MAIL:-/var/spool/mail/$LOGNAME}}}"
@@ -18,7 +19,7 @@
if [[ -d "$file" ]] then
file=( "$file"/**/*(.ND) )
if (($#file)) then
- checkmail "${^file}\?$message"
+ checkmail ${^file}\?$message
fi
elif test -s "$file" -a -N "$file"; then # this also sets $_ to $file
print -r -- "${(e)message:-You have new mail.}"
--
Peter Stephenson <pws@csr.com> Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK Tel: +44 (0)1223 692070
To access the latest news from CSR copy this link into a web browser: http://www.csr.com/email_sig.php
next parent reply other threads:[~2006-09-15 18:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060915174626.GA9429@localhost.localdomain>
2006-09-15 18:07 ` Peter Stephenson [this message]
2006-09-15 18:18 ` arno.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060915190756.832515e8.pws@csr.com \
--to=pws@csr.com \
--cc=zsh-users@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).