zsh-users
 help / color / mirror / code / Atom feed
From: Peter Stephenson <pws@csr.com>
To: zsh-users@sunsite.dk (Zsh users list)
Subject: Re: _all_matches moves cursor
Date: Fri, 06 Oct 2006 11:03:27 +0100	[thread overview]
Message-ID: <200610061003.k96A3RQh019503@news01.csr.com> (raw)
In-Reply-To: <200610060941.k969fbIw017806@news01.csr.com>

Peter Stephenson wrote:
> John Eikenberry wrote:
> > I recently added _all_matches to my completion config [1] and have come
> > across an annoying behaviour. When the '- all matches -' line is longer
> > than my terminal is wide, the cursor (along with the command being
> > completed) gets bounced down a line.
> 
> Here's a slight cheat that simply shortens the line being added.

I've read it more carefully and I think there's simply a bug in the
calculation at this point.  Try this...

Index: Src/Zle/compresult.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Zle/compresult.c,v
retrieving revision 1.65
diff -u -r1.65 compresult.c
--- Src/Zle/compresult.c	11 Aug 2006 21:30:38 -0000	1.65
+++ Src/Zle/compresult.c	6 Oct 2006 10:02:53 -0000
@@ -2126,7 +2126,7 @@
 		if (add)
 		    strcat(buf, " ");
 		strcat(buf, m->str);
-		len -= t;
+		len -= t + add;
 		add = 1;
 	    } else {
 		if (len > add + 2) {

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK                          Tel: +44 (0)1223 692070


To access the latest news from CSR copy this link into a web browser:  http://www.csr.com/email_sig.php


  reply	other threads:[~2006-10-06 10:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-06  5:12 John Eikenberry
2006-10-06  9:41 ` Peter Stephenson
2006-10-06 10:03   ` Peter Stephenson [this message]
2006-10-06 16:29     ` John Eikenberry
2006-10-06 15:47   ` John Eikenberry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200610061003.k96A3RQh019503@news01.csr.com \
    --to=pws@csr.com \
    --cc=zsh-users@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).