zsh-users
 help / color / mirror / code / Atom feed
From: Peter Stephenson <pws@csr.com>
To: zsh-users@sunsite.dk (Zsh users list)
Subject: Re: zsh 4.3.3 released
Date: Tue, 17 Apr 2007 15:06:45 +0100	[thread overview]
Message-ID: <20070417150645.b6d62e3c.pws@csr.com> (raw)
In-Reply-To: <200704171342.l3HDgehc000575@news01.csr.com>

Peter Stephenson <pws@csr.com> wrote:
> Thorsten Kampe wrote:
> > Could I have a confirmation for this? Was my informal bug report 
> > sufficient or do you need a more detailed description?!
> 
> I haven't yet understood what the problem actually is, nor reproduced it
> yet.

OK, I've found it; it wasn't too hard---all uses of %{ in completion were
basically broken (I'm incrementing the pointer before instead of after
processing the escape character).  Thanks for the report.  See if there are
any problems left after this.

Index: Src/Zle/complist.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Zle/complist.c,v
retrieving revision 1.102
diff -u -r1.102 complist.c
--- Src/Zle/complist.c	2 Apr 2007 13:58:19 -0000	1.102
+++ Src/Zle/complist.c	17 Apr 2007 14:04:08 -0000
@@ -1046,13 +1046,11 @@
 			tcout(TCUNDERLINEEND);
 		    break;
 		case ZWC('{'):
-		    for (p++; *p && (*p != '%' || p[1] != '}'); p++)
+		    for (; *p && (*p != '%' || p[1] != '}'); p++)
 			if (dopr)
 			    putc(*p == Meta ? *++p ^ 32 : *p, shout);
 		    if (*p)
-			p++;
-		    else
-			p--;
+			p += 2;
 		    break;
 		case ZWC('m'):
 		    if (stat) {


-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK                          Tel: +44 (0)1223 692070


To access the latest news from CSR copy this link into a web browser:  http://www.csr.com/email_sig.php

To get further information regarding CSR, please visit our Investor Relations page at http://ir.csr.com/csr/about/overview


  reply	other threads:[~2007-04-17 14:08 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-16 16:47 Peter Stephenson
2007-04-16 23:27 ` Thorsten Kampe
2007-04-17  9:56   ` Christoph Bauer
2007-04-17 12:00     ` Peter Stephenson
2007-04-17 13:29   ` Thorsten Kampe
2007-04-17 13:42     ` Peter Stephenson
2007-04-17 14:06       ` Peter Stephenson [this message]
2007-04-17 16:10         ` Thorsten Kampe
2007-04-17 17:41           ` Thorsten Kampe
2007-04-17 18:13 ` Wayne Davison
2007-04-18 11:41   ` Peter Stephenson
2007-04-19 11:07 ` zsh 4.3.4 released Peter Stephenson
2007-04-20 21:40   ` Mikael Magnusson
2007-04-21  6:09     ` Brian K. White
2007-04-23  9:41     ` Peter Stephenson
2007-04-23 12:50       ` Mikael Magnusson
2007-04-23 13:42         ` Christoph Bauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070417150645.b6d62e3c.pws@csr.com \
    --to=pws@csr.com \
    --cc=zsh-users@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).