From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10910 invoked by alias); 31 Mar 2012 16:11:13 -0000 Mailing-List: contact zsh-users-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Users List List-Post: List-Help: X-Seq: 16940 Received: (qmail 9451 invoked from network); 31 Mar 2012 16:11:11 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.2 Received-SPF: pass (ns1.primenet.com.au: SPF record at internecto.net designates 176.9.245.29 as permitted sender) X-Virus-Scanned: Debian amavisd-new at mx1.internecto.net Date: Sat, 31 Mar 2012 18:00:50 +0200 From: Mark To: zsh-users@zsh.org Subject: Re: Catch URLs (was: "Literal" command execution) Message-ID: <20120331180050.29e0f78a@internecto.net> In-Reply-To: <20120213125759.416c7016@pwslap01u.europe.root.pri> References: <20120123205150.27077e4eea9d7be1e632508f@users.sf.net> <35878fa4ecfd0dee27367340676d7b30@voidzero.net> <20120213125759.416c7016@pwslap01u.europe.root.pri> Organization: Internecto SIS X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.10; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Hi, On Mon, 13 Feb 2012 12:57:59 +0000 Peter Stephenson wrote: > On Mon, 13 Feb 2012 12:38:55 +0000 > wrote: > > url-quote-magic:68: array parameter reply created globally in > > function url-quote-magic:72: array parameter reply created globally > > in function > > I don't think reply can be need outside url-quote-magic, can it? > In fact, the function itself doesn't use it either --- ideally zstyle > should have a mechanism for making it local within itself. > > Index: Functions/Zle/url-quote-magic > =================================================================== > RCS file: /cvsroot/zsh/zsh/Functions/Zle/url-quote-magic,v > retrieving revision 1.3 > diff -p -u -r1.3 url-quote-magic > --- Functions/Zle/url-quote-magic 11 Jul 2008 19:12:24 > -0000 1.3 +++ Functions/Zle/url-quote-magic 13 Feb 2012 > 12:56:17 -0000 @@ -60,6 +60,7 @@ > # Use compsys for nested quoting analysis and command parsing. > > # Establish default values for styles, but only if not already set > +local -a reply > > zstyle -m ':url-quote-magic:\*' url-metas '*' || > zstyle ':url-quote-magic:*' url-metas '*?[]^(|)~#{}=' > Hmm, I have recently upgraded zsh and although I saw your patch included, the error came back. Apparently I had fixed it manually. Please see below. I wonder whether this method is ideal for you. Thanks, Mark diff -pU1 old/url-quote-magic new/url-quote-magic --- old/url-quote-magic 2012-03-31 17:58:23.646634259 +0200 +++ new/url-quote-magic 2012-03-31 17:57:13.587013805 +0200 @@ -68,3 +68,3 @@ zstyle -m ':url-quote-magic:\*' url-meta zstyle -m ':url-quote-magic:\*' url-seps '*' || - zstyle -e ':url-quote-magic:*' url-seps 'reply=(";&<>${histchars[1]}")' + zstyle -e ':url-quote-magic:*' url-seps 'local -a reply; reply=(";&<>${histchars[1]}")' @@ -72,3 +72,3 @@ zstyle -m :url-quote-magic url-globbers zstyle -e :url-quote-magic url-globbers \ - 'zmodload -i zsh/parameter; + 'local -a reply; zmodload -i zsh/parameter; reply=( noglob