From: Valodim Skywalker <valodim@mugenguild.com>
To: zsh-users@zsh.org
Subject: Re: Large LS_COLORS makes auto_cd very slow
Date: Fri, 6 Apr 2012 20:30:22 +0200 [thread overview]
Message-ID: <20120406183022.GA11651@mugenguild.com> (raw)
In-Reply-To: <120404005237.ZM10249@torch.brasslantern.com>
[-- Attachment #1: Type: text/plain, Size: 1195 bytes --]
> For each of these categories, _setup line 12 rebuilds the value of
> the _comp_colors array to add new patterns such that any pattern that
> started with '=' gets copied with a prefix matching the tag currently
> being tested; e.g. '(commands)=...' or '(jobs)=...'
>
> This is done even for tags that won't have any matches because the
> colors array has to be ready for the internals to use when a match is
> found, there's no way to "call back" to build it on demand.
>
> The expensive bit is that _comp_colors is declared as a unique array,
> so every time it gets rebuilt the resulting 1700+ entries are all
> compared against one another to make sure there is no duplication.
> Repeat that nine times and it takes a while.
Are these steps all hard requirements? I don't have a good overview of
things, but some of these parts seem like they could be rethought to
work faster or the cpu/memory tradeoff shifted a bit towards more memory
use or something. Does the array really need to be unique? How much
fluctuation is in these contexts, this is a frequent operation so maybe
caching the entries, possibly only for known often called contexts,
could help?
- V
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2012-04-06 18:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-03 19:08 Jesper Nygårds
2012-04-04 7:52 ` Bart Schaefer
2012-04-04 16:57 ` Jesper Nygårds
2012-04-05 9:30 ` Václav Zeman
2012-04-05 15:51 ` Bart Schaefer
2012-04-05 16:33 ` Bart Schaefer
2012-04-05 17:00 ` Philippe Troin
2012-04-06 9:49 ` Václav Zeman
2012-04-06 11:07 ` Mark van Dijk
2012-04-06 15:51 ` Bart Schaefer
2012-04-09 8:23 ` Václav Zeman
2012-04-09 19:28 ` Bart Schaefer
2012-04-06 18:30 ` Valodim Skywalker [this message]
2012-04-07 16:43 ` Bart Schaefer
2013-01-11 11:30 Completing all possible candidates Jesper Nygårds
2013-01-11 14:32 ` Bart Schaefer
2013-01-15 7:28 ` Jesper Nygårds
2013-01-17 3:14 ` Bart Schaefer
2013-01-17 6:28 ` Jesper Nygårds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120406183022.GA11651@mugenguild.com \
--to=valodim@mugenguild.com \
--cc=zsh-users@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).