zsh-users
 help / color / mirror / code / Atom feed
From: Peter Stephenson <p.stephenson@samsung.com>
To: Zsh hackers list <zsh-users@zsh.org>
Subject: Re: ${^var} and word splitting
Date: Mon, 24 Nov 2014 15:55:24 +0000	[thread overview]
Message-ID: <20141124155524.0739b3ec@pwslap01u.europe.root.pri> (raw)
In-Reply-To: <20141124152628.GA5749@chaz.gmail.com>

On Mon, 24 Nov 2014 15:26:28 +0000
Stephane Chazelas <stephane.chazelas@gmail.com> wrote:
> If I understand correctly, in zsh the removing of those are
> accounted to null-removal in things like:
> 
> $ print -l $=a
> 1
> 2
> 3
> 
> But then it's not clear why they are removed there and not in:
> 
> a=':a::b:'
> IFS=:
> print -l $=a

I looked at the code and you're exactly right: it's not clear.  There's
a parameter determining how the split function behaves and there's an
argument allownull that I already noted I didn't understand in the
comment to sepsplit(), determining whether the argument being set will
be empty or will be set to something that has no effect except
preventing the argument being removed later.  In the case in question
this is zero.

Consequently it's easy to change the behaviour in the second case...
This doesn't cause any test failures.  Unless anyone has any ideas why
we do this, maybe we should simplify it like this?  If anyone does have
ideas, we should write a test for that case.

There's one other case in parameter substitution to do with assignment
within the substitution that presumably ought to be consistent.

diff --git a/Src/subst.c b/Src/subst.c
index 61aa1c1..17f35be 100644
--- a/Src/subst.c
+++ b/Src/subst.c
@@ -3322,7 +3322,7 @@ paramsubst(LinkList l, LinkNode n, char **str, int qt, int pf_flags)
 	    isarr = 0;
 	}
 	if (!ssub && (spbreak || spsep)) {
-	    aval = sepsplit(val, spsep, 0, 1);
+	    aval = sepsplit(val, spsep, 1, 1);
 	    if (!aval || !aval[0])
 		val = dupstring("");
 	    else if (!aval[1])

pws


  reply	other threads:[~2014-11-24 16:05 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-24  9:56 Stephane Chazelas
2014-11-24 11:12 ` Peter Stephenson
     [not found] ` <20141124111201.161d8cf2__23261.8202259347$1416827641$gmane$org@pwslap01u.europe.root.pri>
2014-11-24 15:26   ` Stephane Chazelas
2014-11-24 15:55     ` Peter Stephenson [this message]
2014-11-24 16:55       ` Bart Schaefer
2014-11-24 17:22         ` Peter Stephenson
     [not found]     ` <20141124155524.0739b3ec__26419.4987401881$1416845250$gmane$org@pwslap01u.europe.root.pri>
2014-11-24 21:18       ` Stephane Chazelas
2014-11-25  7:49         ` Bart Schaefer
     [not found]         ` <141124234931.ZM17259__8246.8130779036$1416901919$gmane$org@torch.brasslantern.com>
2014-11-25 12:12           ` Stephane Chazelas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141124155524.0739b3ec@pwslap01u.europe.root.pri \
    --to=p.stephenson@samsung.com \
    --cc=zsh-users@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).