zsh-users
 help / color / mirror / code / Atom feed
From: Peter Stephenson <p.stephenson@samsung.com>
To: undisclosed-recipients: ;
Cc: Zsh Users <zsh-users@zsh.org>
Subject: Re: warning about closing an already closed file descriptor
Date: Tue, 20 Jan 2015 11:39:43 +0000	[thread overview]
Message-ID: <20150120113943.27f2d110@pwslap01u.europe.root.pri> (raw)
In-Reply-To: <20150120110203.GI979@isis.sigpipe.cz>

On Tue, 20 Jan 2015 12:02:03 +0100
Roman Neuhauser <neuhauser@sigpipe.cz> wrote:
> > -  ({ exec 3<&- } 2>/dev/null
> > -  exec 3<&-
> > -  read foo <&-)
> > +  (exec {varid}<&0
> > +  exec {varid}<&-
> > +  print About to close a second time >&2
> > +  read {varid}<&-)
> 
> sorry if i'm talking out of my ass, but does this mean that
> the non-{varid} syntax is now without a test?

For closing fd's, yes.  There's no output to test --- though there is a
status, so we could still test that.  And I suppose the lack of an error
message is itself a test...

pws

diff --git a/Test/A04redirect.ztst b/Test/A04redirect.ztst
index cb67788..13f1f7c 100644
--- a/Test/A04redirect.ztst
+++ b/Test/A04redirect.ztst
@@ -152,11 +152,16 @@
 >hello
 >goodbye
 
+  ({exec 3<&- } 2>/dev/null
+   exec 3<&-
+   read foo <&-)
+1:'<&-' redirection with numeric fd (no error message on failure)
+
   (exec {varid}<&0
   exec {varid}<&-
   print About to close a second time >&2
   read {varid}<&-)
-1:'<&-' redirection
+1:'<&-' redirection with fd in variable (error message on failure)
 ?About to close a second time
 *?\(eval\):*: failed to close file descriptor *
 


  reply	other threads:[~2015-01-20 11:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-19 13:33 Kamil Dudka
2015-01-19 14:59 ` Peter Stephenson
2015-01-19 17:28   ` Peter Stephenson
2015-01-20  9:36     ` Kamil Dudka
2015-01-20 11:02     ` Roman Neuhauser
2015-01-20 11:39       ` Peter Stephenson [this message]
2015-01-20 11:43         ` Roman Neuhauser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150120113943.27f2d110@pwslap01u.europe.root.pri \
    --to=p.stephenson@samsung.com \
    --cc=zsh-users@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).