From: Han Pingtian <hanpt@linux.vnet.ibm.com>
To: zsh-users@zsh.org
Subject: Re: device cannot be completed after "ip link show dev"
Date: Wed, 1 Apr 2015 18:07:19 +0800 [thread overview]
Message-ID: <20150401100718.GB2805@localhost.localdomain> (raw)
In-Reply-To: <20150331195701.4bc78e7c@ntlworld.com>
On Tue, Mar 31, 2015 at 07:57:01PM +0100, Peter Stephenson wrote:
> On Mon, 30 Mar 2015 11:39:30 +0800
> Han Pingtian <hanpt@linux.vnet.ibm.com> wrote:
> > Although in _ip() the "link_show_cmds" is defined to
> >
> > 188 local -a link_show_cmds
> > 189 _regex_words link-show-commands 'link show commands' \
> > 190 'dev:specify device:$subcmd_dev' \
> > 191 'up:limit display to running devices'
> > 192 link_show_cmds=("(" $subcmd_dev "|" ")" "$reply[@]" "#" )
> > 193
> >
> > but the device cannot be completed after "ip link show dev":
>
> I see the problem: we're matching way too much where we think there
> might be a dev already on the command line.
>
What's going on when
% ip link show dev <tab>
, please? It looks like the old pattern
/$'[[:alnum:][:punct:][:cntrl:][:digit:]]##\0'/ will match here, so the
action ':interfaces:network interface:_net_interfaces' will be bypassed?
But I think there is nothing at the position of <tab>, why the old
pattern would match a empty string?
> This is better. There's still a possible glitch: if a device springs
> into existence dynamically we won't accept it as a device already part
> of the command line argument, though we will still complete it as that
> calls _net_interfaces again. I think that's fairly minor.
>
I have tested (by set a fake net_intf_list) that if there is a interface
which named "dev", the completion will fail with this patch.
And I have figured out this works:
subcmd_dev=(
/$'[[:alnum:][:punct:][:cntrl:][:digit:]]##\0'/
-'if [[ $words[CURRENT-1] = dev ]];then false;else true;fi'
':interfaces:network interface:_net_interfaces'
)
next prev parent reply other threads:[~2015-04-01 11:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-30 3:39 Han Pingtian
2015-03-31 1:27 ` Eric Cook
2015-03-31 4:52 ` Bart Schaefer
2015-04-01 0:52 ` Han Pingtian
2015-03-31 18:57 ` Peter Stephenson
2015-04-01 10:07 ` Han Pingtian [this message]
2015-04-01 12:15 ` Peter Stephenson
2015-04-01 15:47 ` Bart Schaefer
2015-04-02 8:03 ` Han Pingtian
2015-04-02 16:55 ` Bart Schaefer
2015-04-02 17:00 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150401100718.GB2805@localhost.localdomain \
--to=hanpt@linux.vnet.ibm.com \
--cc=zsh-users@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).