histbeep doesn't work?

histbeep doesn't work?

[Han Pingtian]

Hi,

How to trigger the beep when failing to access a history entry? I cannot
do it:

% zsh -f
localhost% setopt beep histbeep
localhost% !?aaaaa?
zsh: no such event: aaaaa
localhost%

But there is no beep. Although it beeps when pressing tab after "ls".

Thanks!

Re: histbeep doesn't work?

[Bart Schaefer]

On Apr 2,  3:00pm, Han Pingtian wrote:
} 
} How to trigger the beep when failing to access a history entry?

HISTBEEP doesn't refer to bang-history, it refers to history motions
in the ZLE widget set.

Re: histbeep doesn't work?

[Han Pingtian]

On Thu, Apr 02, 2015 at 08:37:18AM -0700, Bart Schaefer wrote:
> On Apr 2,  3:00pm, Han Pingtian wrote:
> } 
> } How to trigger the beep when failing to access a history entry?
> 
> HISTBEEP doesn't refer to bang-history, it refers to history motions
> in the ZLE widget set.

I'd like to suggest clarify the doc something like this:

---
 Doc/Zsh/options.yo | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Doc/Zsh/options.yo b/Doc/Zsh/options.yo
index 19920ca..d1f9a23 100644
--- a/Doc/Zsh/options.yo
+++ b/Doc/Zsh/options.yo
@@ -809,7 +809,7 @@ pindex(NOHISTBEEP)
 cindex(history beeping)
 cindex(beep, history)
 item(tt(HIST_BEEP) <D>)(
-Beep when an attempt is made to access a history entry which
+Beep in ZLE widget when an attempt is made to access a history entry which
 isn't there.
 )
 pindex(HIST_EXPIRE_DUPS_FIRST)
-- 
1.9.3

Re: histbeep doesn't work?

[Bart Schaefer]

On Apr 3, 11:14am, Han Pingtian wrote:
}
} > HISTBEEP doesn't refer to bang-history, it refers to history motions
} > in the ZLE widget set.
} 
} I'd like to suggest clarify the doc something like this:
} 
} -Beep when an attempt is made to access a history entry which
} +Beep in ZLE widget when an attempt is made to access a history entry which
}  isn't there.

Perhaps "Beep in ZLE when a widget attempts to access ..." but this
change is otherwise fine.

Re: histbeep doesn't work?

[Han Pingtian]

On Fri, Apr 03, 2015 at 09:14:54AM -0700, Bart Schaefer wrote:
> On Apr 3, 11:14am, Han Pingtian wrote:
> }
> } > HISTBEEP doesn't refer to bang-history, it refers to history motions
> } > in the ZLE widget set.
> } 
> } I'd like to suggest clarify the doc something like this:
> } 
> } -Beep when an attempt is made to access a history entry which
> } +Beep in ZLE widget when an attempt is made to access a history entry which
> }  isn't there.
> 
> Perhaps "Beep in ZLE when a widget attempts to access ..." but this
> change is otherwise fine.

Thanks. I have composed a new patch according to your suggestion.


>From 7c0ff8a0f0e01c33c84ec5b5bab546b84a41a841 Mon Sep 17 00:00:00 2001
From: Han Pingtian <hanpt@linux.vnet.ibm.com>
Date: Fri, 3 Apr 2015 11:09:39 +0800
Subject: [PATCH] clarifying doc of HIST_BEEP

Signed-off-by: Han Pingtian <hanpt@linux.vnet.ibm.com>
---
 Doc/Zsh/options.yo | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Doc/Zsh/options.yo b/Doc/Zsh/options.yo
index 19920ca..8540256 100644
--- a/Doc/Zsh/options.yo
+++ b/Doc/Zsh/options.yo
@@ -809,7 +809,7 @@ pindex(NOHISTBEEP)
 cindex(history beeping)
 cindex(beep, history)
 item(tt(HIST_BEEP) <D>)(
-Beep when an attempt is made to access a history entry which
+Beep in ZLE when a widget attempts to access a history entry which
 isn't there.
 )
 pindex(HIST_EXPIRE_DUPS_FIRST)
-- 
1.9.3