zsh-users
 help / color / mirror / code / Atom feed
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: "Jun T." <takimoto-j@kba.biglobe.ne.jp>
Cc: phy1729@gmail.com, zsh-users@zsh.org
Subject: Re: zsh 5.0.8-test-2
Date: Sun, 23 Aug 2015 08:31:46 +0000	[thread overview]
Message-ID: <20150823083146.GA7537@tarsus.local2> (raw)
In-Reply-To: <9306B4F4-68C3-4EC5-93FD-A40346692465@kba.biglobe.ne.jp>

Jun T. wrote on Sat, Aug 22, 2015 at 20:48:47 +0900:
> -#ifdef USE_DEV_PTMX
> +#if defined(USE_DEV_PTMX) && !defined(__OpenBSD__)

Wouldn't it be better to change configure to avoid defining the macro in
the first place on OpenBSD?  This would matter if more uses of
USE_DEV_PTMX in C file are added: the knowledge that "don't USE_DEV_PTMX
on OpenBSD" should be consolidated in one place.

IIRC $OSTYPE is the variable to test.


  parent reply	other threads:[~2015-08-23  8:31 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-21 20:50 Peter Stephenson
2015-08-22  0:10 ` Matthew Martin
2015-08-22  0:30   ` Michael Beasley
2015-08-22  0:45     ` Matthew Martin
2015-08-22 11:48   ` Jun T.
2015-08-22 17:04     ` Matthew Martin
2015-08-23  8:31     ` Daniel Shahaf [this message]
2015-08-23 12:45       ` Jun T.
2015-08-28  2:05 ` string to array space problem in filenames Ray Andrews
2015-08-28  3:15   ` Mikael Magnusson
2015-08-28 18:54     ` Ray Andrews
2015-08-28 19:43       ` Bart Schaefer
2015-08-28 20:42         ` Ray Andrews
2015-08-28 20:56         ` Peter Stephenson
2015-09-03  3:37         ` Ray Andrews
2015-09-03  4:48           ` Kurtis Rader
2015-09-03  5:25           ` Bart Schaefer
2015-09-03  5:53             ` Mikael Magnusson
2015-09-03 15:23             ` Ray Andrews
2015-09-03 15:30               ` Mikael Magnusson
2015-09-03 15:58                 ` Ray Andrews
2015-09-03 16:08                   ` Peter Stephenson
2015-09-03 16:11                 ` Ray Andrews
2015-09-03 17:11                   ` Ray Andrews
     [not found]                 ` <55E86E0C.1000806__15798.3473306105$1441295967$gmane$org@eastlink.ca>
2015-09-03 16:21                   ` Stephane Chazelas
2015-08-28  9:40   ` Peter Stephenson
2015-08-28 19:02     ` Ray Andrews
2015-08-28 19:45       ` Bart Schaefer
2015-08-28 20:35         ` Ray Andrews

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150823083146.GA7537@tarsus.local2 \
    --to=d.s@daniel.shahaf.name \
    --cc=phy1729@gmail.com \
    --cc=takimoto-j@kba.biglobe.ne.jp \
    --cc=zsh-users@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).