zsh-users
 help / color / mirror / code / Atom feed
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Shlomi Fish <shlomif@gmail.com>
Cc: Peter Stephenson <p.stephenson@samsung.com>, zsh-users@zsh.org
Subject: Re: The zsh equivalent to Bash's "complete -W" to complete a command using only a list of words
Date: Sat, 09 Apr 2016 17:45:18 +0000	[thread overview]
Message-ID: <20160409174518.GA10166@tarsus.local2> (raw)
In-Reply-To: <CANy4znWAhsamgKrpOqmWCNqOWuzwzvXRLSWL6=X8bo6CeH-eZg__45121.4810986587$1460209332$gmane$org@mail.gmail.com>

Shlomi Fish wrote on Sat, Apr 09, 2016 at 16:40:52 +0300:
>     compdef "_values $description $val1 $val2 $val3 $val4..." Theme
> 
> Where $description is a short description and $val1 $val2 are the values.

That's vulnerable to shell injection.

You need either to change "" to '' or to change «$foo» to «${(q)foo}»,
depending on whether you intend the variables to be interpolated at the
time you run compdef or at the time you invoke the completion.

Cheers,

Daniel
(I realize you might have intended those variables as metasyntax...)


      parent reply	other threads:[~2016-04-09 17:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-09 10:27 Shlomi Fish
2016-04-09 11:45 ` Peter Stephenson
2016-04-09 13:40   ` Shlomi Fish
2016-04-09 13:49     ` Peter Stephenson
2016-04-09 14:49       ` Bart Schaefer
     [not found]   ` <CANy4znWAhsamgKrpOqmWCNqOWuzwzvXRLSWL6=X8bo6CeH-eZg__45121.4810986587$1460209332$gmane$org@mail.gmail.com>
2016-04-09 17:45     ` Daniel Shahaf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160409174518.GA10166@tarsus.local2 \
    --to=d.s@daniel.shahaf.name \
    --cc=p.stephenson@samsung.com \
    --cc=shlomif@gmail.com \
    --cc=zsh-users@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).